- Issue created by @cmlara
- Merge request !15Issue #3485510 by cmlara: Make create() method in base classes abstract → (Merged) created by cmlara
Automatically closed - issue fixed for 2 weeks with no activity.
PHPStan has warned that returning static can be confusing and depends significantly upon class extension.
Some modules try and use the create() method to retain BC using the model of
public static function create(...) {
$object = parent::create(..)
$object->newProperty = something
}however this has pitfalls that variables may never be fully initialized if the constructor is called directly. While the constructor could be marked @internal, this forces the setup to always use the create 'factory' when not needed.
While this has become somewhat a Drupalism to construct methods in the create() method I would rather we create an ecosystem where the constructor is expected to handle class setup.
We can mark the method abstract on base classes to allow extension by other classes, and provide BC as we already do as part of the base class constructor.
Make create() method abstract in base classes.
Classes extending our base classes MUST implement the create() method. This may
Active
3.0
Code
Automatically closed - issue fixed for 2 weeks with no activity.