- Issue created by @byrond
- πΊπΈUnited States byrond
Bumping this to Major, because the supported release claims it is compatible with Drupal 11, but it will not install without this dependency constraint change, and PHPUnit tests fail with Drupal 11. It's likely this was never tested with D11 prior to that release.
- πΊπΈUnited States byrond
Looks like that is a schema issue with PDF API, which was probably present before this MR, since the module wouldn't even install to run tests for Drupal 11 prior to this change. I can look into it, but if someone who is more familiar with this module knows how to fix this, that would be helpful.
The only change included in this issue is to allow wa72/htmlpagedom to install a later version of 3.0, which is compatible with Drupal 11.
- Status changed to Needs review
about 2 months ago 9:29pm 14 January 2025 - πΊπΈUnited States byrond
Version 3.1.3 will not install on Drupal 11, and as a result, never passed tests. I'm not sure what the path forward is for this, since I don't think the changes in this MR caused the failing tests. Before this MR, Composer would not even install the module to be tested.
See https://git.drupalcode.org/issue/printable-3485496/-/jobs/3266867
If tests are required to pass before merging this, I would recommend pulling the 3.1.3 release or at least not marking it as compatible with D11.
The problem with not merging this is that Drupal 11 sites using this module cannot simply patch it, since Composer will not allow it to install due to the dependency issue. We had to fork the module and point Composer to our version, and other sites will need to do the same.
- πΊπΈUnited States byrond
It looks like the original updates for Drupal 11 were only tested with Drupal 10:
https://git.drupalcode.org/project/printable/-/jobs/2053860I confirmed this MR also passes on Drupal 10:
https://git.drupalcode.org/issue/printable-3485496/-/jobs/4021489 - πΊπΈUnited States byrond
I tracked the test failure down to π Config schema for chroot does not match usage Active and am working on an MR for that now.