Dependency version constraint block Drupal 11 upgrade

Created on 4 November 2024, 10 months ago

Problem/Motivation

wa72/htmlpagedom is a module dependency. The constraint currently only allows 3.0.0, and Symfony 7 compatibility was only added in 3.0.2. Since Drupal 11 requires Symfony 7, this constraint will block the upgrade.

https://packagist.org/packages/wa72/htmlpagedom

Steps to reproduce

Add the Printable module to a Drupal 10 site. Try to upgrade to Drupal 11.

Proposed resolution

Update the constraint to include "^3.0"

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Active

Version

3.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States byrond

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @byrond
  • Merge request !44Update wa72/htmlpagedom version constraint β†’ (Merged) created by byrond
  • πŸ‡ΊπŸ‡ΈUnited States byrond
  • Pipeline finished with Failed
    10 months ago
    Total: 192s
    #329495
  • πŸ‡ΊπŸ‡ΈUnited States byrond

    Bumping this to Major, because the supported release claims it is compatible with Drupal 11, but it will not install without this dependency constraint change, and PHPUnit tests fail with Drupal 11. It's likely this was never tested with D11 prior to that release.

  • πŸ‡ΊπŸ‡ΈUnited States markdorison

    Tests are failing.

  • πŸ‡ΊπŸ‡ΈUnited States byrond

    Looks like that is a schema issue with PDF API, which was probably present before this MR, since the module wouldn't even install to run tests for Drupal 11 prior to this change. I can look into it, but if someone who is more familiar with this module knows how to fix this, that would be helpful.

    The only change included in this issue is to allow wa72/htmlpagedom to install a later version of 3.0, which is compatible with Drupal 11.

  • Pipeline finished with Failed
    9 months ago
    Total: 174s
    #361373
  • Status changed to Needs review 8 months ago
  • πŸ‡ΊπŸ‡ΈUnited States byrond

    Version 3.1.3 will not install on Drupal 11, and as a result, never passed tests. I'm not sure what the path forward is for this, since I don't think the changes in this MR caused the failing tests. Before this MR, Composer would not even install the module to be tested.

    See https://git.drupalcode.org/issue/printable-3485496/-/jobs/3266867

    If tests are required to pass before merging this, I would recommend pulling the 3.1.3 release or at least not marking it as compatible with D11.

    The problem with not merging this is that Drupal 11 sites using this module cannot simply patch it, since Composer will not allow it to install due to the dependency issue. We had to fork the module and point Composer to our version, and other sites will need to do the same.

  • Pipeline finished with Failed
    8 months ago
    Total: 300s
    #396045
  • Pipeline finished with Failed
    8 months ago
    Total: 290s
    #396050
  • πŸ‡ΊπŸ‡ΈUnited States byrond

    It looks like the original updates for Drupal 11 were only tested with Drupal 10:
    https://git.drupalcode.org/project/printable/-/jobs/2053860

    I confirmed this MR also passes on Drupal 10:
    https://git.drupalcode.org/issue/printable-3485496/-/jobs/4021489

  • πŸ‡ΊπŸ‡ΈUnited States byrond

    I tracked the test failure down to πŸ› Config schema for chroot does not match usage Active and am working on an MR for that now.

  • Pipeline finished with Failed
    2 months ago
    Total: 200s
    #541133
  • πŸ‡ΊπŸ‡ΈUnited States bsnodgrass

    We have run into this. Anything new on a MR?

  • First commit to issue fork.
  • Pipeline finished with Failed
    about 2 months ago
    Total: 1707s
    #560701
  • Pipeline finished with Failed
    about 2 months ago
    Total: 178s
    #560777
  • Pipeline finished with Failed
    about 2 months ago
    Total: 183s
    #560803
  • Pipeline finished with Failed
    about 2 months ago
    Total: 258s
    #560985
  • Pipeline finished with Failed
    about 2 months ago
    Total: 287s
    #560992
  • Pipeline finished with Failed
    about 2 months ago
    Total: 196s
    #561383
  • Pipeline finished with Failed
    about 2 months ago
    Total: 170s
    #561388
  • Pipeline finished with Running
    about 1 month ago
    #561730
  • Pipeline finished with Failed
    about 1 month ago
    Total: 171s
    #561753
  • Pipeline finished with Success
    about 1 month ago
    Total: 206s
    #561757
  • πŸ‡΅πŸ‡±Poland piotrsmykaj

    Please review the patch.

  • πŸ‡΅πŸ‡±Poland piotrsmykaj

    Patch against specific version 3.1.3.

  • Pipeline finished with Success
    about 1 month ago
    Total: 423s
    #562429
  • πŸ‡΅πŸ‡±Poland piotrsmykaj

    Patch against specific version 3.1.3 with the removed entity as a null option.

  • πŸ‡¦πŸ‡ΊAustralia nigelcunningham Geelong

    Apologies for my slowness in getting onto this. Looking at it now.

    Thanks all of you for your work.

  • πŸ‡¦πŸ‡ΊAustralia nigelcunningham Geelong
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024