Dependency version constraint block Drupal 11 upgrade

Created on 4 November 2024, 2 months ago

Problem/Motivation

wa72/htmlpagedom is a module dependency. The constraint currently only allows 3.0.0, and Symfony 7 compatibility was only added in 3.0.2. Since Drupal 11 requires Symfony 7, this constraint will block the upgrade.

https://packagist.org/packages/wa72/htmlpagedom

Steps to reproduce

Add the Printable module to a Drupal 10 site. Try to upgrade to Drupal 11.

Proposed resolution

Update the constraint to include "^3.0"

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Active

Version

3.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States byrond

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @byrond
  • Merge request !44Update wa72/htmlpagedom version constraint β†’ (Open) created by byrond
  • πŸ‡ΊπŸ‡ΈUnited States byrond
  • Pipeline finished with Failed
    2 months ago
    Total: 192s
    #329495
  • πŸ‡ΊπŸ‡ΈUnited States byrond

    Bumping this to Major, because the supported release claims it is compatible with Drupal 11, but it will not install without this dependency constraint change, and PHPUnit tests fail with Drupal 11. It's likely this was never tested with D11 prior to that release.

  • πŸ‡ΊπŸ‡ΈUnited States markdorison

    Tests are failing.

  • πŸ‡ΊπŸ‡ΈUnited States byrond

    Looks like that is a schema issue with PDF API, which was probably present before this MR, since the module wouldn't even install to run tests for Drupal 11 prior to this change. I can look into it, but if someone who is more familiar with this module knows how to fix this, that would be helpful.

    The only change included in this issue is to allow wa72/htmlpagedom to install a later version of 3.0, which is compatible with Drupal 11.

Production build 0.71.5 2024