Redirect to TFA doesn't work with login destination modules

D.O. has migrated away from patch files.

In order for tests to run we require all submissions to be in the form of a Merge Request.

More details may be found at: https://www.drupal.org/docs/develop/git/using-gitlab-to-contribute-to-dr... →

Initial thoughts are why we should be even touching the Global Request.. Turns out this is from a OLD core bug that this was even needed. 🐛 Allow form redirects to ignore ?destination query parameter Fixed .

https://www.drupal.org/node/3375113 → for how this would apply to newer versions of core.

That all aside, it appears this is the way it needs to be for now and matches code later in the same class.

Forcing commit to bypass tests due to issues from 🐛 beStrictAboutOutputDuringTests=true or failOnRisky=true causing test failures due to PHP8.4 Implicit Nullable deprecation Active .

I believe this will need to ported to 2.x.

🐛 Original page lost after TOTP authentication Active does not on cursory glance appear to be applicable as this is our 'force to redirect' where we do want to ignore the destination.

Just reporting this anecdotally for now, as I can imagine it will want dealing with in its own issue, but similar to this report, I've found destination strings on reset password links break the TFA flow too. On following the link, users are sent to the destination in the URL, instead of to the TFA entry page - so may then see a 403 page as they couldn't complete logging in.