Hidden filters in a collapsible details element still display the summary

Created on 3 November 2024, 4 months ago

Problem/Motivation

When adding a block with a hidden exposed filter, when the filter is set to be in a details element (base functionality of the FilterWidgetBase used by Better Exposed Filters), the filter is hidden but the wrapping details element and its summary (field label) is still shown.

Steps to reproduce

Proposed resolution

This is a follow-up or a twin to πŸ› Hidden filters with a fieldset still display the fieldset legend Fixed so we can extend that solution to _collapsible tagged details elements.

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Active

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States mlncn Minneapolis, MN, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @mlncn
  • Pipeline finished with Failed
    4 months ago
    Total: 245s
    #328044
  • πŸ‡ΊπŸ‡ΈUnited States mlncn Minneapolis, MN, USA
  • Status changed to Needs review 19 days ago
  • πŸ‡ΊπŸ‡ΈUnited States danflanagan8 St. Louis, US

    I ran into this exact problem. I'm upgrading all my facets blocks to native exposed filters in facets 3.0. The plan there is to lean heavily on this excellent configurable_views_filter_block module. I'm wanting to use collapsible bef filters and experienced the same thing in the IS.

    I left a couple comments in the MR. There are a couple of if conditions that seem a bit off.

    That said, the patch works for me and I'm going to use it. (Thanks, @mlncn!)

    The concerns I have with the if conditions aren't going to affect my site. I do think the fix would be more robust if the conditions were modified slightly per my comments though.

  • πŸ‡ΊπŸ‡ΈUnited States danflanagan8 St. Louis, US
Production build 0.71.5 2024