Wrong check removes nested filters completely

Created on 1 November 2024, 6 months ago

Problem/Motivation

https://git.drupalcode.org/project/search_api_swiftype/-/commit/321aea64... introduced a new check to skip nested filter processing, if there are no filters for a document type. Unfortunately the $nested_filters[$document_type] variable is no array there, but an object/stdClass - thus both is_array() and count() checks are failing and the nested filter is never added.

Steps to reproduce

Set up your index to contain a condition group with nested filter(s) and see those are never applied

Proposed resolution

Also handle the case that $nested_filters[$document_type] may be an object as well

Remaining tasks

Create issue fork and MR to fix this issue

User interface changes

n/a

API changes

n/a

Data model changes

n/a

🐛 Bug report

Status

Active

Version

10.0

Component

Code

Created by

🇩🇪Germany hctom

Live updates comments and jobs are added and updated live.

Merge Requests

!4Wrong check removes nested filters completely
Merged
🇩🇪Germany hctom
updated 19 days ago

Comments & Activities

Issue created by @hctom
Merge request !4#3485073 Wrong check removes nested filters → (Merged) created by hctom
Comment 6 months ago →
🇩🇪Germany hctom
Please see the issue fork and MR for a fix for this issue. This also fixes a warning, if there is no $nested_filters[$document_type] item at all.
Comment 6 months ago →
🇩🇪Germany hctom
Better issue title
Status changed to Needs review 19 days ago1:41pm 7 April 2025
First commit to issue fork.
Comment 19 days ago →
System Message

stborchert → committed 5cbb45f2 on 10.x authored by hctom →
#3485073 Wrong check removes nested filters
Comment 19 days ago →
🇩🇪Germany stborchert
Comment 5 days ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024