Contrib.social

Deprecate two EntityCeDisplay methods

Open on Drupal.org →
Created on 29 October 2024, 4 months ago

Problem/Motivation

It's unfortunate, but I already created some public methods in EntityCeDisplayInterface that are just unnecessary:

  • setOriginalMode(): I never wanted to create this but thought it was necessary because we need to set a class property $originalMode that is protected, from 'outside'.
    • That was dumb, because ConfigEntityInterface::set() exists.
  • getConfigDependencyEntityViewDisplays(): Near the end of 🐛 Config dependencies are not properly calculated Needs work (just before 3.0.0 had to be released) I argued for making this public because I wanted to reuse/call it from the form.

Proposed resolution

I would rather set a good example for the future, even though deprecating methods so early is weird. So:

  • Remove both methods from the interface
  • Mark the public methods as @deprecated. (In the case of getConfigDependencyEntityViewDisplays(), this means making it public again; the public-to-protected change was only commited to -dev so far.)

...because in principle, someone could be calling these two methods from another class.

Remaining tasks

Review MR.

Write short change record mentioning the 2 deprecations.

📌 Task
Status

Active

Version

3.0

Component

Code

Created by

🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024