- Issue created by @jjchinquist
- 🇮🇳India abhishek_virasat
I have fixed the issue and created Patch. please review it once
- 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
Fixed by direct push to 3.x branch; see commit.
@abhishek_gupta1 please remove the notifications you have (apparently) set up for the custom_elements module; I will from now on feel free to silently ignore any contributions I get through Virasat Solutions, and not credit you, if things cost us extra time. Reason:
- Review of your patch:
- It does absolutely nothing. There is no functional change; you have just replaced a new PHP construct by an old one
- It introduces unnecessary space changes in an otherwise unchanged line
- Do not add comments to say exactly what the next (simple) line does. It's not helpful / adds no informatiib. Comments may be useful to say why code is doing something; otherwise, generally, just don't add them.
- In 📌 Drupal 11 compatibility fixes for custom_elements 3.x Active ,
- sarwan_varma just created extra work for us (by making things incompatible with Drupal 10.2). If we did things ourselves and ignored the contribution, we would be faster.
- I credited him anyway. But this has crossed a line: I am not going to do this anymore, or feel obliged to give any reply that costs me time for no clear benefit.
- Review of your patch:
Automatically closed - issue fixed for 2 weeks with no activity.