Update core compatability in oembed_providers_test.info.yml

Created on 25 October 2024, 5 months ago

Problem/Motivation

When adding D11 support, the oembed_providers_test test module was missed.

Core tests are currently failing on 11.x:

Running with gitlab-runner 17.5.2 (c6eae8d7)
  on gitlab-runner-6dd988d654-qvnk8 s8ex1X2yJ, system ID: r_EFUc8A4vR1Ul
  feature flags: FF_NETWORK_PER_BUILD:true
Resolving secrets
Preparing the "kubernetes" executor 00:00
"CPURequest" overwritten with "2"
Using Kubernetes namespace: gitlab-runner
Using Kubernetes executor with image drupalci/php-8.3-apache:production ...
Using attach strategy to execute scripts...
Preparing environment 00:31
Using FF_USE_POD_ACTIVE_DEADLINE_SECONDS, the Pod activeDeadlineSeconds will be set to the job timeout: 1h0m0s...
Waiting for pod gitlab-runner/runner-s8ex1x2yj-project-62745-concurrent-6-517jwjf5 to be running, status is Pending
	ContainersNotInitialized: "containers with incomplete status: [init-permissions]"
	ContainersNotReady: "containers with unready status: [build helper svc-0 svc-1]"
	ContainersNotReady: "containers with unready status: [build helper svc-0 svc-1]"
Running on runner-s8ex1x2yj-project-62745-concurrent-6-517jwjf5 via gitlab-runner-6dd988d654-qvnk8...
Getting source from Git repository 00:01
Fetching changes with git depth set to 50...
Initialized empty Git repository in /builds/project/oembed_providers/.git/
Created fresh repository.
Checking out 86653609 as detached HEAD (ref is 2.x)...
Skipping Git submodules setup
Downloading artifacts 00:06
Downloading artifacts for composer (3157946)...
Downloading artifacts from coordinator... ok        host=drupal-gitlab-job-artifacts.s3.us-west-2.amazonaws.com id=3157946 responseStatus=200 OK token=glcbt-64
Executing "step_script" stage of the job script 00:37
$ echo "COMPOSER_END_CODE=$COMPOSER_END_CODE" # collapsed multi-line command
COMPOSER_END_CODE=0
$ if [ "$_SHOW_ENVIRONMENT_VARIABLES" == "1" ]; then # collapsed multi-line command
$ mkdir -p $BROWSERTEST_OUTPUT_DIRECTORY
$ mkdir -p $CI_PROJECT_DIR/$_WEB_ROOT/sites/default/files/simpletest
$ chmod -R 755 $BROWSERTEST_OUTPUT_DIRECTORY
$ chmod -R 755 $CI_PROJECT_DIR/$_WEB_ROOT/sites/default/files/simpletest
$ ln -s $CI_PROJECT_DIR/$_WEB_ROOT /var/www/html
$ chown -R www-data:www-data $CI_PROJECT_DIR
$ service apache2 start
Starting Apache httpd web server: apache2.
$ [[ $_TARGET_DB_TYPE == "sqlite" ]] && export SIMPLETEST_DB=sqlite://localhost/sites/default/files/db.sqlite # collapsed multi-line command
$ php -r "include '$CI_PROJECT_DIR/vendor/autoload.php'; echo 'Drupal: ' . \Drupal::VERSION . PHP_EOL;" # collapsed multi-line command
Drupal: 11.0.5
PHP 8.3.13 (cli) (built: Oct 24 2024 16:00:41) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.3.13, Copyright (c) Zend Technologies
    with Zend OPcache v8.3.13, Copyright (c), by Zend Technologies
$ _PHPUNIT_TESTGROUPS=$(echo $_PHPUNIT_TESTGROUPS | sed -e 's/ //g')
$ if [ "$_PHPUNIT_CONCURRENT" == "0" ]; then # collapsed multi-line command
_PHPUNIT_CONCURRENT=0, _PHPUNIT_TESTGROUPS=--all, _PHPUNIT_EXTRA= WHAT_TO_RUN=
executing: sudo -u www-data -E vendor/bin/phpunit  --bootstrap /builds/project/oembed_providers/web/core/tests/bootstrap.php /builds/project/oembed_providers/web/modules/custom/oembed_providers --log-junit /builds/project/oembed_providers/junit.xml  
PHPUnit 10.5.37 by Sebastian Bergmann and contributors.
Runtime:       PHP 8.3.13
FFFFFF.........E................................................  64 / 64 (100%)
Time: 00:32.268, Memory: 8.00 MB
There was 1 error:
1) Drupal\Tests\oembed_providers\Kernel\ProviderRepositoryTest::testProvidersAlterHook
Drupal\Core\Extension\MissingDependencyException: Unable to install modules: module 'oembed_providers_test' is incompatible with this version of Drupal core.
/builds/project/oembed_providers/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:119
/builds/project/oembed_providers/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/builds/project/oembed_providers/tests/src/Kernel/ProviderRepositoryTest.php:20
--
There were 6 failures:
1) Drupal\Tests\oembed_providers\Functional\CustomProviderRepositoryTest::testCustomProviderLoading
Unable to install modules: module 'oembed_providers_test' is incompatible with this version of Drupal core.
/builds/project/oembed_providers/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:505
/builds/project/oembed_providers/web/core/tests/Drupal/Tests/BrowserTestBase.php:554
/builds/project/oembed_providers/web/core/tests/Drupal/Tests/BrowserTestBase.php:363
/builds/project/oembed_providers/web/core/modules/media/tests/src/Functional/MediaFunctionalTestTrait.php:62
/builds/project/oembed_providers/tests/src/Functional/CustomProviderRepositoryTest.php:38
2) Drupal\Tests\oembed_providers\Functional\CustomProvidersUiTest::testRoutePermissions
Unable to install modules: module 'oembed_providers_test' is incompatible with this version of Drupal core.
/builds/project/oembed_providers/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:505
/builds/project/oembed_providers/web/core/tests/Drupal/Tests/BrowserTestBase.php:554
/builds/project/oembed_providers/web/core/tests/Drupal/Tests/BrowserTestBase.php:363
/builds/project/oembed_providers/tests/src/Functional/CustomProvidersUiTest.php:48
3) Drupal\Tests\oembed_providers\Functional\ExternalFetchTest::testExternalFetch
Unable to install modules: module 'oembed_providers_test' is incompatible with this version of Drupal core.
/builds/project/oembed_providers/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:505
/builds/project/oembed_providers/web/core/tests/Drupal/Tests/BrowserTestBase.php:554
/builds/project/oembed_providers/web/core/tests/Drupal/Tests/BrowserTestBase.php:363
/builds/project/oembed_providers/tests/src/Functional/ExternalFetchTest.php:45
4) Drupal\Tests\oembed_providers\Functional\ProviderBucketTest::testRoutePermissions
Unable to install modules: module 'oembed_providers_test' is incompatible with this version of Drupal core.
/builds/project/oembed_providers/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:505
/builds/project/oembed_providers/web/core/tests/Drupal/Tests/BrowserTestBase.php:554
/builds/project/oembed_providers/web/core/tests/Drupal/Tests/BrowserTestBase.php:363
/builds/project/oembed_providers/tests/src/Functional/ProviderBucketTest.php:52
5) Drupal\Tests\oembed_providers\Functional\ProviderBucketTest::testProviderBucketForm
Unable to install modules: module 'oembed_providers_test' is incompatible with this version of Drupal core.
/builds/project/oembed_providers/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:505
/builds/project/oembed_providers/web/core/tests/Drupal/Tests/BrowserTestBase.php:554
/builds/project/oembed_providers/web/core/tests/Drupal/Tests/BrowserTestBase.php:363
/builds/project/oembed_providers/tests/src/Functional/ProviderBucketTest.php:52
6) Drupal\Tests\oembed_providers\Functional\ProviderBucketTest::testProviderBucketDependencyCalculation
Unable to install modules: module 'oembed_providers_test' is incompatible with this version of Drupal core.
/builds/project/oembed_providers/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:505
/builds/project/oembed_providers/web/core/tests/Drupal/Tests/BrowserTestBase.php:554
/builds/project/oembed_providers/web/core/tests/Drupal/Tests/BrowserTestBase.php:363
/builds/project/oembed_providers/tests/src/Functional/ProviderBucketTest.php:52
ERRORS!
Tests: 64, Assertions: 177, Errors: 1, Failures: 6, PHPUnit Deprecations: 2.
$ cp /var/log/apache2/test.apache.access.log $CI_PROJECT_DIR/apache.access.log.txt
$ cp /var/log/apache2/test.apache.error.log $CI_PROJECT_DIR/apache.error.log.txt
$ exit $EXIT_CODE
Uploading artifacts for failed job 00:01
Uploading artifacts...
junit.xml: found 1 matching artifact files and directories 
/builds/project/oembed_providers/web/sites/default/files/simpletest: found 1 matching artifact files and directories 
/builds/project/oembed_providers/web/sites/simpletest/browser_output: found 1 matching artifact files and directories 
apache.access.log.txt: found 1 matching artifact files and directories 
apache.error.log.txt: found 1 matching artifact files and directories 
Uploading artifacts as "archive" to coordinator... 201 Created  id=3157956 responseStatus=201 Created token=glcbt-64
Uploading artifacts...
junit.xml: found 1 matching artifact files and directories 
WARNING: /builds/project/oembed_providers/web/sites/default/files/simpletest/phpunit-*.xml: no matching files. Ensure that the artifact path is relative to the working directory (/builds/project/oembed_providers) 
Uploading artifacts as "junit" to coordinator... 201 Created  id=3157956 responseStatus=201 Created token=glcbt-64
Cleaning up project directory and file based variables 00:01
ERROR: Job failed: command terminated with exit code 2

Proposed resolution

Update oembed_providers_test.info.yml to add D11 support and to drop D9 support.

Remaining tasks

  • Open MR
  • Passing tests

User interface changes

None

API changes

None

Data model changes

None

πŸ› Bug report
Status

Active

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States Chris Burge

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024