Some processors call generate() with bogus $key field.

Created on 25 October 2024, about 1 month ago

Problem/Motivation

Some processors call generate() with bogus 3rd $key parameter. See commit.

This was committed as part of 📌 Add auto-formatter that uses regular processors Active but it never did anything, because the 3rd parameter to generate() has always been '$language'.
It doesn't need to do anything / generate() doesn't need to set any "key" / element name / Tag; that has always been done afterwards by the 'parent' DefaultFieldItemListProcessor.

This does not show actual buggy behavior, unless the configured "key" happens to be the same as an existing language.

Proposed resolution

I'm going to commit the fix myself, directly to the main branch. I just wanted to open a separate issue to comment on this behavior.
(Found when working on 🐛 Referenced entity in wrong language Active ; I would have just fixed it in there except there's no good indication that that will get merged soon.)

🐛 Bug report
Status

Active

Version

3.0

Component

Code

Created by

🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024