getCampaignId errors when no session

Created on 25 October 2024, about 2 months ago

Problem/Motivation

If you don't have a session (e.g. running via cron), getCampaignId errors.

Proposed resolution

This will fix it using PHP8 and later.

MailchimpEcommerceHelper.php
line 110:
$session_campaign = $this->request->getSession()->get('mc_cid', '');
should change to
$session_campaign = $this->request->getSession()?->get('mc_cid', '');

🐛 Bug report

Status

Active

Version

2.0

Component

Code

Created by

🇦🇺Australia susie

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @susie
Comment 11 days ago →
System Message

xenophyle → committed 1c80dc5b on 2.x
Issue #3483319 by susie: getCampaignId errors when no session
Comment 11 days ago →
🇺🇸United States xenophyle
@susie Since this version still supports PHP 7, I committed a version of your solution that is compatible with that.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024