Contrib.social

Event series form cannot be resaved when custom event recur type is used

Open on Drupal.org →
Created on 23 October 2024, 5 months ago

Problem/Motivation

When the "Custom/Single Event" recur type is chosen but no start and end date are set, the event series form cannot be resaved.

Event managers can hit this problem when they want to prepare the content of an event of which the date has not yet been finalized. They have lost some work because the event was not saved, and no error message or warning was shown so the user was unaware that the updated content was not stored.

Steps to reproduce

  1. Create a new event series.
  2. Set "Recur type" to "Custom/Single event".
  3. Leave the start and end date empty.
  4. Save the form.
  5. Now edit the event series again. Change the title.
  6. Save the form.

Expected result: the event series is saved. When you press "View" you can see the changed title.

Actual result: the event series is not saved. No error or warning is shown. When you press "View" you see the previous version of the event series and all changes are lost.

Proposed resolution

This is caused by a discrepancy in the form data and entity data. The custom_dates field is missing from the form data but present in the entity data. This causes EventCreationService::checkForFormRecurConfigChanges() to return TRUE and the form is reloaded instead of being saved with the intention that the user should confirm changes made to the recurring date setup.

We should make sure the data format aligns between form and entity.

🐛 Bug report
Status

Active

Version

2.0

Component

Recurring Events (Main module)

Created by

🇧🇬Bulgaria pfrenssen Sofia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024