Feeds import not working with cron

I do not have a MS SQL Server driver ready, but based on the error message, I made a change that perhaps works. The error says "Cannot update identity column 'lid'", and the code is passing a value for 'lid' when updating a log entry. So maybe the issue gets fixed when the code no longer passes a value for 'lid'.

Can you try the code from 3482189-cron-sql-server-driver to see if that helps?

I will try, but honestly I'm not super familiar with the new way of doing things. I'm still in the "patch" world. I'll try to get it figured out on Google.

If you click the "plain diff" link, then you get a text file that you could use as a patch.

I figured out to get a patch from your branch but I'm having trouble getting the patch applied.

Could not apply patch! Skipping. The error was: Cannot apply patch https://git.drupalcode.org/issue/feeds-3482189/-/commit/b0c52a15e36251cf...

Here's my patch:

"drupal/feeds": {
"Issue 3482189": "https://git.drupalcode.org/issue/feeds-3482189/-/commit/b0c52a15e36251cf..."
}

Full output in CLI

patch "-p1" --no-backup-if-mismatch -d "E:\wwwroot\zzz/web/modules/contrib/feeds" < "C:\Users\admin\AppData\Local\Temp\9/67167e57ec37b.patch"
patching file src/Result/HttpFetcherResult.php
patching file tests/src/Unit/Result/HttpFetcherResultTest.php
Hunk #1 FAILED at 7.
1 out of 2 hunks FAILED -- saving rejects to file tests/src/Unit/Result/HttpFetcherResultTest.php.rej

patch "-p0" --no-backup-if-mismatch -d "E:\wwwroot\zzz/web/modules/contrib/feeds" < "C:\Users\admin\AppData\Local\Temp\9/67167e57ec37b.patch"
can't find file to patch at input line 16
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|From b0c52a15e36251cfa1c3529ee1d8a2bd2a78f177 Mon Sep 17 00:00:00 2001
|From: znerol <46208-znerol@users.noreply.drupalcode.org>
|Date: Mon, 14 Oct 2024 14:08:50 +0000
|Subject: [PATCH] Issue #3480545 by znerol: Fixed PHP Warning: unlink(): No
| such file or directory in HttpFetcherResult::cleanUp().
|
|---
| src/Result/HttpFetcherResult.php | 2 +-
| tests/src/Unit/Result/HttpFetcherResultTest.php | 2 ++
| 2 files changed, 3 insertions(+), 1 deletion(-)
|
|diff --git a/src/Result/HttpFetcherResult.php b/src/Result/HttpFetcherResult.php
|index fdd803ae..f9966d5c 100644
|--- a/src/Result/HttpFetcherResult.php
|+++ b/src/Result/HttpFetcherResult.php
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
1 out of 1 hunk ignored
can't find file to patch at input line 29
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/tests/src/Unit/Result/HttpFetcherResultTest.php b/tests/src/Unit/Result/HttpFetcherResultTest.php
|index 1dbea793..6060cdfd 100644
|--- a/tests/src/Unit/Result/HttpFetcherResultTest.php
|+++ b/tests/src/Unit/Result/HttpFetcherResultTest.php
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
2 out of 2 hunks ignored

patch "-p2" --no-backup-if-mismatch -d "E:\wwwroot\zzz/web/modules/contrib/feeds" < "C:\Users\admin\AppData\Local\Temp\9/67167e57ec37b.patch"
can't find file to patch at input line 16
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|From b0c52a15e36251cfa1c3529ee1d8a2bd2a78f177 Mon Sep 17 00:00:00 2001
|From: znerol <46208-znerol@users.noreply.drupalcode.org>
|Date: Mon, 14 Oct 2024 14:08:50 +0000
|Subject: [PATCH] Issue #3480545 by znerol: Fixed PHP Warning: unlink(): No
| such file or directory in HttpFetcherResult::cleanUp().
|
|---
| src/Result/HttpFetcherResult.php | 2 +-
| tests/src/Unit/Result/HttpFetcherResultTest.php | 2 ++
| 2 files changed, 3 insertions(+), 1 deletion(-)
|
|diff --git a/src/Result/HttpFetcherResult.php b/src/Result/HttpFetcherResult.php
|index fdd803ae..f9966d5c 100644
|--- a/src/Result/HttpFetcherResult.php
|+++ b/src/Result/HttpFetcherResult.php
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
1 out of 1 hunk ignored
can't find file to patch at input line 29
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/tests/src/Unit/Result/HttpFetcherResultTest.php b/tests/src/Unit/Result/HttpFetcherResultTest.php
|index 1dbea793..6060cdfd 100644
|--- a/tests/src/Unit/Result/HttpFetcherResultTest.php
|+++ b/tests/src/Unit/Result/HttpFetcherResultTest.php
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
2 out of 2 hunks ignored

patch "-p4" --no-backup-if-mismatch -d "E:\wwwroot\zzz/web/modules/contrib/feeds" < "C:\Users\admin\AppData\Local\Temp\9/67167e57ec37b.patch"
can't find file to patch at input line 16
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|From b0c52a15e36251cfa1c3529ee1d8a2bd2a78f177 Mon Sep 17 00:00:00 2001
|From: znerol <46208-znerol@users.noreply.drupalcode.org>
|Date: Mon, 14 Oct 2024 14:08:50 +0000
|Subject: [PATCH] Issue #3480545 by znerol: Fixed PHP Warning: unlink(): No
| such file or directory in HttpFetcherResult::cleanUp().
|
|---
| src/Result/HttpFetcherResult.php | 2 +-
| tests/src/Unit/Result/HttpFetcherResultTest.php | 2 ++
| 2 files changed, 3 insertions(+), 1 deletion(-)
|
|diff --git a/src/Result/HttpFetcherResult.php b/src/Result/HttpFetcherResult.php
|index fdd803ae..f9966d5c 100644
|--- a/src/Result/HttpFetcherResult.php
|+++ b/src/Result/HttpFetcherResult.php
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
1 out of 1 hunk ignored
can't find file to patch at input line 29
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/tests/src/Unit/Result/HttpFetcherResultTest.php b/tests/src/Unit/Result/HttpFetcherResultTest.php
|index 1dbea793..6060cdfd 100644
|--- a/tests/src/Unit/Result/HttpFetcherResultTest.php
|+++ b/tests/src/Unit/Result/HttpFetcherResultTest.php
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
2 out of 2 hunks ignored

Could not apply patch! Skipping. The error was: Cannot apply patch https://git.drupalcode.org/issue/feeds-3482189/-/commit/b0c52a15e36251cf...

> post-package-install: Drupal\Composer\Plugin\Scaffold\Plugin->postPackage
> post-package-install: Laminas\ComponentInstaller\ComponentInstaller->onPostPackageInstall
Generating autoload files
54 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
> post-install-cmd: Drupal\Composer\Plugin\Scaffold\Plugin->postCmd
> post-install-cmd: Drupal\Composer\Plugin\ProjectMessage\MessagePlugin->displayPostCreateMessage
* Homepage: https://www.drupal.org/project/drupal →
* Support:
* docs: https://www.drupal.org/docs/user_guide/en/index.html →
* chat: https://www.drupal.org/node/314178 →

I found the link above
https://git.drupalcode.org/project/feeds/-/merge_requests/203.diff

I applied the patch and there was no error. I cleared cache. I ran cron manually.
The errors are gone in Recent Logs. That part is resolved.

If I filter logs by "Feeds" it doesn't show that the feed was imported just now. While the SQL error was resolved, it still apparently didn't import.

Logs show that feeds_cron() and feeds_log_cron() ran, but no sign of any changes to the entity fields that are imported.

Is there something scheduled to be imported? If not, try to start an import using the “Import in background” link and then run cron. If the feed is currently locked, unlock it first and then try to import in background.

Note: A feed becomes locked when an import for it is started or planned, to prevent running two imports for the same feed at the same time. But if an import abruptly ended due to an error, the feed may remain in a locked state without the import getting continued. In this case, it is good to unlock it manually.

It was locked. I'm unlocking, then importing in background. After this, I'll try a cron run. Thanks for your help.

Cron updated the data. The feeds filter in Logs shows updates at the same time as cron. I think it's working :)

I'm actually having a problem with the scheduled import and cron. When I schedule the feed then run cron, it is incomplete. When I run the feed manually, it takes a lot longer but it's complete.

Any idea why the cron import isn't doing a complete feed import?

Because there is a time limit on cron runs, if your import is large, it can take multiple cron runs to complete an import. Feeds is given about a minute per cron run to do its thing.

OK thanks. I guess I need to look into running it more often.

I merged the code for the issue you had with feeds_log and since it looks like your other issues with the module are now also solved, I'm marking this issue as "fixed".

Feel free to reopen or open a new issue if you experience more issues related to the MS SQL Server Driver. 🙂

Automatically closed - issue fixed for 2 weeks with no activity.