Contrib.social

Brandfolder media picker is a full screen takeover instead of staying inside the modal

Open on Drupal.org →
Created on 18 October 2024, 28 days ago

After updating from Brandfolder 2.0.0-beta1 to 5.0.1, when I open the media picker to select a Brandfolder image as an attachment, it takes over the entire screen. So I have to click the little back arrow to get out of the full screen takeover and then click "Insert selected".

I think the problem is the `position: fixed` in this CSS:

.brandfolder-browser .brandfolder-asset.brandfolder-asset--active {
  position: fixed;
  top: 0;
  left: 0;
  max-width: 100%;
  width: 100%;
  height: 100%;
  box-sizing: border-box;
  z-index: 1;
  display: flex;
  padding: 80px 1rem 1rem 3rem;
  margin: 0;
}

When I change that to `position: absolute` it remains inside the modal popup, which is how it functioned in Brandfolder 2.0.0-beta1.

🐛 Bug report
Status

Active

Version

5.0

Component

Code

Created by

🇺🇸United States wesleymusgrove

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @wesleymusgrove
  • Comment 25 days ago →
    🇺🇸United States ndewhurst USA

    Hi Wesley, thanks for filing. That full-screen takeover was a crude, quick-fix workaround meant to avoid the issue whereby you scroll down through a list of assets, then select one, and then see only whitespace until you scroll back up. See this issue ✨ Entity Browser Selection Active . I just updated the 5.0.x branch with what should be a better fix for that issue.
    I can also confirm that we will be releasing an update on the 6.x branch in the next month that includes a new approach to the asset browser and will help address various UX issues.

  • Comment 25 days ago →
    🇺🇸United States wesleymusgrove

    Very good and thanks for the link! This can be closed.

  • Comment 11 days ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024