Contrib.social

Feedback message type entity doesn't declare its success_message property

Open on Drupal.org →
Created on 17 October 2024, 4 months ago

Problem/Motivation

The feedback_message_type config entity form has a field for a success_message (i.e.: at /admin/structure/feedback_message_type/add), and the config schema has one (see config/schema/feedback_message_type.schema.yml, but the \Drupal\feedback\Entity\FeedbackMessageType itself doesn't declare it.

In a test environment, this means that, if you enter a success_message, it isn't saved.

Steps to reproduce

Run \Drupal\Tests\feedback\Functional\CreateReadUpdateDeleteMessageTypeTest::testCreateMessageType() and \Drupal\Tests\feedback\Functional\CreateReadUpdateDeleteMessageTypeTest::testUpdateMessageType() in the ✨ Add automated tests Active branch.

Proposed resolution

Declare a property, \Drupal\feedback\Entity\FeedbackMessageType->success_message.

Remaining tasks

  1. Write a patch
  2. (skipping review and feedback; it blocks ✨ Add automated tests Active )
  3. (skipping RTBC and feedback; a maintainer wrote it)
  4. Commit

User interface changes

None.

API changes

None.

Data model changes

None; the property is already declared in the config.

🐛 Bug report
Status

Active

Version

3.0

Component

Code

Created by

🇨🇦Canada mparker17 UTC-4

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024