Test-only changes should not revert changes in .info(.yml) and phpunit.xml

The changes are done for the D7 pipeline as well, but here we use .info instead of .info.yml.

I renamed the variable from NON_TEST_CHANGES to CHANGES_TO_REVERT so it more accurately reflects what it contains (reducing brain effort to follow the code)

Tested in this pipeline which has a phpunit.xml and now this does not get reverted
https://git.drupalcode.org/project/scheduler/-/jobs/3068144

Compare this to the job in the issue summary which failed badly when the phpunit.xml file was removed.

Ready for review.

The changes look good and the test above proves that it works properly.
RTBC.

I've also tested the D7 version
https://git.drupalcode.org/project/scheduler/-/jobs/3068466#L413

Two questions:

1. The .gitlab-ci.yml is also reverted in this job. I know it would not make any difference to the pipeline to revert that file after the job has started, but it still looks disconcerting in the log to see

Reverting changes that are not test files
↩️ Reverting .gitlab-ci.yml

so I may add that into the preserve list.

2. Looking at the Drupal 7 core respository I'm not sure we had phpunit.xml files in D7, as I can't see one? Maybe a contrib module could add one anyway, so I don't think it harms to leave that in. Or I can remove it from the grep if that is better?

1. Since we are saying ...that are not test files I think it's fine, but happy if you want to add it to the list.
2. I think it's fine to leave it. If a module has that file in the D7 codebase, let's use it.

I added .gitlab-ci.yml into the preserve list, and left phpunit.xml in too.

Tested in D11
https://git.drupalcode.org/project/scheduler/-/jobs/3079848#L391

Tested in D7
https://git.drupalcode.org/project/scheduler/-/jobs/3079696#L408

The changes since your RTBC are minor, and the test runs work as expected, so I'm leaving the status as RTBC

Merged. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.