Review D7 pipelines with D11 shift changes

The downstream api-d7 pipeline is affected by 🐛 Fix php_version in Drupal 7 pipelines Active , but we can at least see the info message added about the variables, as I don't think we have a way to detect whether these have been set up by the project (eg: https://git.drupalcode.org/project/api/-/blob/7.x-2.x/.gitlab-ci.yml?ref...)

But the MR is ready for initial review and even testing on other D7 projects.

For reference, to see the state of things before testing this MR, here is a Sheduler 7.x pipeline using the 'main' ref, but no other changes.
https://git.drupalcode.org/project/scheduler/-/pipelines/309345
The PHPUnit jobs fail with

-- install-drupal --
You are about to create a /builds/project/scheduler/web/sites/default/settings.php file and DROP all tables in your 'mysql' database. Do you want to continue? (y/n): y
Failed to create database: ERROR 3554 (HY000) at line 1: Access to   [error]
system table 'mysql.innodb_index_stats' is rejected.

The regular branch test (using 'default-ref') passes OK.
https://git.drupalcode.org/project/scheduler/-/pipelines/309385

Testing against MR271, the 'Max PHP' phpunit tests now pass, which is great.

But the 'current' composer in this MR now uses PHP5.6 which has Composer 1, so it fails now. Before it used PHP 8.1 and passed OK. The MR sets $CORE_LEG_PHP_MIN for _TARGET_D7_PHP which is the minimum I guess, but not the recommend default? I had already thought that we should add a new variable $CORE_LEG_PHP (or something), which can be used for "current" and is neither the _MIN nor the _MAX.

https://git.drupalcode.org/project/scheduler/-/pipelines/309403

Good idea. Added a new variable for 8.1 as that's the recommended per https://www.drupal.org/docs/7/system-requirements/php-requirements-for-d... →

Re-run pipeline passed with the new variable $CORE_LEG_PHP: 8.1
https://git.drupalcode.org/project/scheduler/-/pipelines/309490

Thanks for applying the suggestions to the linked lines in the repo. I have modifed the title to reflect the change, but is is unfortunate how large the capital letters are now in the new d.o. font :-)

I don't think we have a way to detect whether these have been set up by the project

Yes I'm not sure. I can investigate that later, and we may also deprecate _TARGET_PHP like we did with _TARGET_CORE, so that can be wrapped up in future. No reason for this not to be RTBC and get it fixed now before the big Step 3 shift.

Thanks for the testing / fixes / feedback. Merged!

Automatically closed - issue fixed for 2 weeks with no activity.