- Issue created by @delmarr
- πΊπΈUnited States bronzehedwick New York
I'm seeing almost the opposite.
- When I set the caption to be visible, it stays visible
- When I set the caption to be hidden, is also stays visible (no
visually-hidden
class is applied) - After setting the caption to be hidden, and editing the node again, the editor says the caption is visible
Since the caption is always visible, and the editor always reflects that, my guess is that the caption visible state isn't being saved properly, and that could account for the display issue. Interesting that this is essentially the reverse of what you're seeing @delmarr. Are you still seeing the behavior you're describing in this ticket?
The problem was with the Tabled plugin, see: https://github.com/Lullabot/tabled/issues/7
When the plugin was created, I didn't include the check for the `hide-caption` attribute that the CKE button adds to the `caption` element which is an indication that the user has choose to hide the caption.
The issue that was mentioned with styles at
css/responsiveTableStyles.css
that are referencing afigcation
element that doesn't exists should be addressed in a different issue.There is also another issue with the Tabled plugin which is that the navigation should be set to
display: none
when it's not necessary since it's creating some white space between the caption and the table when the controls aren't present, this should be addressed as a new issue on the Tabled plugin.- πΊπΈUnited States bronzehedwick New York
Hey @javi-er, thank you! After this update, I am seeing the caption be visually hidden if toggled off, and shown if not.
However, if I try to change the setting from visible to hidden or vice versa after I've saved the node, the option doesn't change. I think this is a big improvement, though, so fine if we want to handle that in a separate issue.
Thanks for the review @bronzehedwick ! there was an extra issue that I fixed, could you take another look please?
- πΊπΈUnited States bronzehedwick New York
Re-tested and it's working great. Thanks @javi-er!
-
javi-er β
committed 813ddd1c on 1.0.x
Issue #3480235: Toggling the displaying of the caption
-
javi-er β
committed 813ddd1c on 1.0.x
- Assigned to javi-er
- Status changed to Fixed
8 days ago 7:59pm 10 December 2024 Automatically closed - issue fixed for 2 weeks with no activity.