- Issue created by @pookmish
- πΊπΈUnited States pookmish
pookmish β changed the visibility of the branch 3480225-disabled-displays-can to hidden.
- πΊπΈUnited States pookmish
pookmish β changed the visibility of the branch 3480225-disabled-displays-can to active.
- πΊπΈUnited States pookmish
MR opened, and patch provided for any composer patches.
- First commit to issue fork.
- πΊπΈUnited States danflanagan8 St. Louis, US
Thanks for the issue! I'm surprised this isn't a dupe, but I don't see any similar reports in the queue.
I added some test coverage to the MR. Let's see how that runs in Gitlab.
- πΊπΈUnited States danflanagan8 St. Louis, US
Perfect! Without the fix the updated test fails with:
1) Drupal\Tests\viewfield\FunctionalJavascript\ViewfieldWidgetTest::testSelectWidget Behat\Mink\Exception\ExpectationException: An option "block_disabled" exists in select "field_view_test[0][display_id]", but it should not.
With the fix it passes. The fix itself looks good to the eye as well. Let's merge.
Thanks!
-
danflanagan8 β
committed f4a2e498 on 8.x-3.x authored by
pookmish β
Issue #3480225 by pookmish, danflanagan8: Disabled displays can be...
-
danflanagan8 β
committed f4a2e498 on 8.x-3.x authored by
pookmish β
Automatically closed - issue fixed for 2 weeks with no activity.