- Issue created by @longwave
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
This sure would make
Component
config entity IDs feel less "alien" to experienced Drupal developers.I'm +1 to giving this a try! 👍
- Merge request !360Replace plus with dot in component config entity IDs → (Merged) created by longwave
- 🇬🇧United Kingdom longwave UK
Find and replace did not take long so I just did it while 📌 [later phase] [PP-2] Prepare for multiple component types: prefix Component config entity IDs with `sdc` Postponed was fresh in my mind, but postponing as that needs to land first.
- 🇬🇧United Kingdom longwave UK
I also spotted that the regex currently disallows dotted SDC names and we have test coverage for this too:
'INVALID: period separated' => ['period.separated+period.separated]', FALSE],
If these are valid, we can deal with them in a followup.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
I literally can't find the reason documented in 📌 "Developer-created components": mark which SDCs should be exposed in XB Fixed nor in any Slack history.
To the best of my knowledge, we picked
+
as the separator because.
might be a valid character in the name of an SDC.But now I think allowing a period in the SDC plugin ID (for example
foo.bar.component.yml
to define afoo.bar
SDC) is simply an oversight.
Since #3444417, I learned of other gaps in SDC'sComponentPluginManager
, such as happily accepting SDC props names containing dashes, even though Twig does not allow dashes in variable names, and hence SDC allows for props names that are impossible to use in Twig! 🙈 See 📌 Twig disallows dashes in variable names, so SDC should disallow it in prop names Active .This undeniably looks more familiar/less alien to Drupal developers. So, even though I'd like @f.mazeikis to sign off on this, I think this is a clear improvement towards making XB look more familiar/less alien to the rest of the Drupal community.
-
wim leers →
committed ea0beedc on 0.x authored by
longwave →
Issue #3480193 by longwave, wim leers: Replace plus with dot in...
-
wim leers →
committed ea0beedc on 0.x authored by
longwave →
Automatically closed - issue fixed for 2 weeks with no activity.