Many kernel tests depend on super user status

1) Drupal\Tests\registration_admin_overrides\Kernel\Plugin\Validation\Constraint\RegistrationConstraintTest::testRegistrationConstraintRegression Failed asserting that 1 matches expected 0. /builds/issue/registration-3464498/vendor/phpunit/phpunit/src/Framework/Constraint/Equality/IsEqual.php:95 /builds/issue/registration-3464498/modules/registration_admin_overrides/tests/src/Kernel/Plugin/Validation/Constraint/RegistrationConstraintTest.php:222 /builds/issue/registration-3464498/vendor/phpunit/phpunit/src/Framework/TestResult.php:729 2) Drupal\Tests\registration_admin_overrides\Kernel\Plugin\Validation\Constraint\RegistrationConstraintTest::testRegistrationConstraintWithOverrides Failed asserting that 1 matches expected 0. /builds/issue/registration-3464498/vendor/phpunit/phpunit/src/Framework/Constraint/Equality/IsEqual.php:95 /builds/issue/registration-3464498/modules/registration_admin_overrides/tests/src/Kernel/Plugin/Validation/Constraint/RegistrationConstraintTest.php:291 /builds/issue/registration-3464498/vendor/phpunit/phpunit/src/Framework/TestResult.php:729 3) Drupal\Tests\registration_waitlist\Kernel\RegistrationWaitListStateTransitionAccessTest::testWaitlistStateTransitionAccess Failed asserting that false is true. /builds/issue/registration-3464498/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:122 /builds/issue/registration-3464498/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:56 /builds/issue/registration-3464498/modules/registration_waitlist/tests/src/Kernel/RegistrationWaitListStateTransitionAccessTest.php:141 /builds/issue/registration-3464498/vendor/phpunit/phpunit/src/Framework/TestResult.php:729 4) Drupal\Tests\registration_workflow\Kernel\RegistrationWorkflowStateTransitionTest::testWorkflowStateTransitions Failed asserting that an array has the key 'hold'. /builds/issue/registration-3464498/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:122 /builds/issue/registration-3464498/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:56 /builds/issue/registration-3464498/modules/registration_workflow/tests/src/Kernel/RegistrationWorkflowStateTransitionTest.php:53 /builds/issue/registration-3464498/vendor/phpunit/phpunit/src/Framework/TestResult.php:729 5) Drupal\Tests\registration\Kernel\Plugin\Field\Formatter\RegistrationHostEntityFormatterTest::testRegistrationHostEntityFormatter Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'My event' +'' /builds/issue/registration-3464498/vendor/phpunit/phpunit/src/Framework/Constraint/Equality/IsEqual.php:95 /builds/issue/registration-3464498/tests/src/Kernel/Plugin/Field/Formatter/RegistrationHostEntityFormatterTest.php:37 /builds/issue/registration-3464498/vendor/phpunit/phpunit/src/Framework/TestResult.php:729 6) Drupal\Tests\registration\Kernel\Plugin\Field\Formatter\RegistrationIdFormatterTest::testRegistrationIdFormatter Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'<a href="/registration/1" hreflang="en">1</a>' +'1' /builds/issue/registration-3464498/vendor/phpunit/phpunit/src/Framework/Constraint/Equality/IsEqual.php:95 /builds/issue/registration-3464498/tests/src/Kernel/Plugin/Field/Formatter/RegistrationIdFormatterTest.php:31 /builds/issue/registration-3464498/vendor/phpunit/phpunit/src/Framework/TestResult.php:729 7) Drupal\Tests\registration\Kernel\Plugin\Validation\Constraint\RegistrationConstraintTest::testRegistrationConstraint Failed asserting that 1 matches expected 0. /builds/issue/registration-3464498/vendor/phpunit/phpunit/src/Framework/Constraint/Equality/IsEqual.php:95 /builds/issue/registration-3464498/tests/src/Kernel/Plugin/Validation/Constraint/RegistrationConstraintTest.php:213 /builds/issue/registration-3464498/vendor/phpunit/phpunit/src/Framework/TestResult.php:729 8) Drupal\Tests\registration\Kernel\RegistrationManagerTest::testRegistrationManager Failed asserting that an array has the key 'registration_registrant_type_anon'. /builds/issue/registration-3464498/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:122 /builds/issue/registration-3464498/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:56 /builds/issue/registration-3464498/tests/src/Kernel/RegistrationManagerTest.php:93 /builds/issue/registration-3464498/vendor/phpunit/phpunit/src/Framework/TestResult.php:729 FAILURES!

Comments & Activities

Issue created by @jonathanshaw
Comment 2 months ago →
🇬🇧United Kingdom jonathanshaw Stroud, UK
RegistrationAccessTest creates a user (and doesn't use it) in setUp() in order to avoid this problem, so that this unused user is the superuser.
@jonathanshaw opened merge request.
Comment 2 months ago →
🇬🇧United Kingdom jonathanshaw Stroud, UK
It's kind of an annoying issue, but I think what I'm doing here is right. Tests that have an implict dependency on the hidden mystic powers of the superuser are easy to get wrong, it's better to be very explicit about the user and their permissions. The proof of this is in modules/registration_waitlist/tests/src/Kernel/RegistrationWaitListStateTransitionAccessTest.php which actually wasn't testing what it looked like it was testing, because the superuser was making the test too easy to pass.
Comment 2 months ago →
🇬🇧United Kingdom jonathanshaw Stroud, UK
Even more signficantly, addressing this surfaced a significant bug in RegistrationOverrideChecker that prevented anyone from overriding the maximum spaces constraint.
Comment 2 months ago →
🇺🇸United States john.oltman
It's kind of an annoying issue, but I think what I'm doing here is right.

Totally agree. Thanks for all the work you are putting in.
Comment 2 months ago →
🇺🇸United States john.oltman
Comment 2 months ago →
🇬🇧United Kingdom jonathanshaw Stroud, UK
Fixed
Comment 2 months ago →
System Message

john.oltman → committed 2b782602 on 3.3.x authored by jonathanshaw →
#3480028 by jonathanshaw: Many kernel tests depend on super user status
Comment 2 months ago →
System Message

john.oltman → committed 4fd029a1 on 3.1.x authored by jonathanshaw →
#3480028 by jonathanshaw: Many kernel tests depend on super user status
Comment 2 months ago →
🇺🇸United States john.oltman
Comment about 2 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Many kernel tests depend on super user status

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities