Contrib.social

Fix PHPStan and CSpell warnings in CI

Open on Drupal.org →
Created on 10 October 2024, about 1 month ago

Problem/Motivation

Since commit 9903645b, Gitlab CI has been raising CI warnings for both PHPStan and CSpell.

See https://git.drupalcode.org/project/maintenance_exempt/-/commits/8.x-1.x showing CI previously passing and then starting to raise warnings.

We should fix these issues and decide whether we should make passing PHPStan and CSpell without warnings be mandatory for merging.

Or decide that we don't want to be compliant with PHPStan and CSpell, in which case we should opt out.

Note these warnings are not generated by the code changes, I suspect the Drupal Gitlab CI has changed in that period (eg via https://www.drupal.org/project/gitlab_templates/issues/3395419 → ?).

Steps to reproduce

View https://git.drupalcode.org/project/maintenance_exempt/-/commits/8.x-1.x and see failing commits.

Proposed resolution

Fix issues or opt out.

Remaining tasks

All the things.

User interface changes

None.

API changes

TBD.

Data model changes

None.

📌 Task
Status

Active

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom Eli-T Manchester

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024