Contrib.social

Cloned entity are not set to published even if save as published box is checked.

Open on Drupal.org →
Created on 9 October 2024, about 1 year ago

Problem/Motivation

Save as published is not working as designed

Steps to reproduce

  • Clone an entity
  • Set save entity as published to true
  • Save cloned entity
  • Cloned entity takes default moderation state not published

Proposed resolution

After I checked the module set status of the cloned entity to 1 without also making sure moderation state is set to published based on the save as published checkbox so we need to do that.

Note: for me it checks for moderation state in $properties['moderation_state'] but there is no moderation state there it also doesn't take the save as published result in consideration.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

2.1

Component

Code

Created by

🇯🇴Jordan Ibrahim Tameme

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Ibrahim Tameme
  • Merge request !92Issue-3479601: set moderation state to publshed if status is true → (Merged) created by Ibrahim Tameme
  • Pipeline finished with Failed
    about 1 year ago
    Total: 511s
    #305047
  • Comment 3 months ago →
    🇷🇺Russia kiseleva.t

    Exported MR into patch.

  • First commit to issue fork.
  • Pipeline finished with Failed
    3 months ago
    Total: 262s
    #565112
  • Comment 3 months ago →
    hrgadev

    #4

  • Comment 2 months ago →
    🇸🇮Slovenia deaom

    Setting status to needs review, did test it and can confirm the issue is present if using content moderation module. The MR solves the issue by forcing the status to publish in case the checkbox is checked. If checkbox is not checked the status is copied from original entity.
    The failing tests are due to the action UI module no longer being present in core (from D10.3) and maintainers need to decide if they want to add contributed module dependency or remove action from testing.

  • Pipeline finished with Success
    about 2 months ago
    Total: 486s
    #589938
  • Comment about 2 months ago →
    🇸🇮Slovenia deaom

    Branch is re-based and tests are passing. Not sure if any additional test are needed/required so leaving status to needs review.

  • Pipeline finished with Success
    about 2 months ago
    Total: 166s
    #589968
  • Comment about 2 months ago →
    🇮🇳India rajeshreeputra Pune

    looks good, added to merge train.

  • Status changed to RTBC about 1 month ago
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024