- Issue created by @jonathan1055
- 🇬🇧United Kingdom jonathan1055
Here's an initial attempt. I've been running this job but cannot get the
rules:
to trigger correctly yet. - 🇪🇸Spain fjgarlin
Great idea on the ".pre" job. At first I thought it was just invalid syntax, but yeah, having just
variables:
seems to be valid syntax under GitLab CI standards, but the side effects of it are totally not expected (empty variables!!). - 🇬🇧United Kingdom jonathan1055
The trick to getting the
rules:
criteria working properly was to check againstnull
not an empty string. It sounds obvious now, but I don't think we have ever tested a variable for null before in the templates. The conditions==""
and!=""
were both evaluating to false, so I did some research on what it should be checking for, and foundnull
Test with
variables:
followed by no variable definitions:
https://git.drupalcode.org/project/scheduler/-/pipelines/305371After removing the empty variables: line
https://git.drupalcode.org/project/scheduler/-/pipelines/305375 - 🇬🇧United Kingdom jonathan1055
Here's the job using 'alpine' image. Worked fine.
https://git.drupalcode.org/project/scheduler/-/jobs/3004765 - 🇪🇸Spain fjgarlin
Looks pretty good already. Just added some minor feedback to expand the
if
condition a little to match theprintf
values that we show. - 🇬🇧United Kingdom jonathan1055
I've responded in the MR and this is ready for review.
Here's a re-run of the test https://git.drupalcode.org/project/scheduler/-/pipelines/306428 -
fjgarlin →
committed a8e090c8 on main authored by
jonathan1055 →
Issue #3479581 by jonathan1055, fjgarlin: Better failure if there are no...
-
fjgarlin →
committed a8e090c8 on main authored by
jonathan1055 →
Automatically closed - issue fixed for 2 weeks with no activity.