- Issue created by @jonathan1055
- 🇪🇸Spain fjgarlin
My thinking is that:
- The "current" and any "previous" variants should use stable core tags (currently, "previous" variants use tags, but "current" uses a dev branch)
- For "next" (minor or major), we can use dev branches (that's how it is now). - 🇬🇧United Kingdom jonathan1055
Yes. I have updated the issue summary with the examples from 'check versions' which show which jobs use the variables.
- 🇬🇧United Kingdom jonathan1055
I have pushed an initial change to use
CORE_STABLE
instead ofCORE_SUPPORTED
for the current and Max PHP jobs.Previously I had noted that there were several variables not being used anywhere in the jobs.
CORE_STABLE
was one of these that was not used. Now that we are using it, we are no longer usingCORE_SUPPORTED
anywhere. - 🇪🇸Spain fjgarlin
I think you forgot to create the MR 🙂 (I can see the changes using the "compare" link).
In any case, we should update the info on this section of the docs: https://project.pages.drupalcode.org/gitlab_templates/info/variants/#use...
- 🇬🇧United Kingdom jonathan1055
Tested on Scheduler. The Composer current and Max PHP jobs show
drupal/core 11.0.5
when before they had
drupal/core 11.0.x-dev c2b9161
Full pipeline here https://git.drupalcode.org/project/scheduler/-/pipelines/303877
- 🇪🇸Spain fjgarlin
The changes look good to me. Thanks for creating the issue and working on it.
This should made contrib pipelines more stable.
RTBC. - 🇬🇧United Kingdom jonathan1055
is it worth you triggering the downstream pipelines? I know it worked for one test, but would not harm trying it on the others.
- 🇪🇸Spain fjgarlin
I thought I did, but you're right, I didn't. Here: https://git.drupalcode.org/issue/gitlab_templates-3479303/-/pipelines/30...
-
fjgarlin →
committed bf13af09 on main authored by
jonathan1055 →
Issue #3479303 by jonathan1055, fjgarlin: Use stable core versions
-
fjgarlin →
committed bf13af09 on main authored by
jonathan1055 →
-
fjgarlin →
committed d3eda785 on main
Issue #3479303: Changelog.
-
fjgarlin →
committed d3eda785 on main
Automatically closed - issue fixed for 2 weeks with no activity.