Address new phpstan issues

Open on Drupal.org →

Created on 8 October 2024, 5 months ago

Sometime in the past few weeks there have been some big changes made to the GitLab CI phpstan configurations, with the result that we are now seeing dozens of phpstan warnings and errors for things that it didn't used to complain about. And there have been other changes, like the definition of what constitutes "alphabetical order" has changed in the past few weeks, so that "use" statements that were in alphabetical order a few weeks ago are no longer considered to be in alphabetical order anymore.

There have been no change records or other notifications about these changes.

This issue is so I can have a place to work on solving some of these things.

📌 Task

Status

Active

Version

4.0

Component

Rules Core

Created by

🇺🇸United States tr Cascadia

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!76Address new phpstan issues
Open
🇺🇸United States tr
updated 2 months ago

Comments & Activities

Issue created by @tr
Merge request !76Language context parameter is optional → (Open) created by tr
Comment 5 months ago →
🇺🇸United States tr Cascadia
Comment 3 months ago →
🇺🇸United States tr Cascadia
Use statements were fixed in 📌 Re-sort use statements using the new alphabetical ordering Active
Comment 3 months ago →
🇺🇸United States tr Cascadia
The MR fixes everything, but it mixes up a lot of different issues and some fixes unrelated to phpcs (but discovered by phpcs) are mixed in here.

So I'm turning this into a meta issue so that the fixes are a lot more narrow - I find that helps greatly when looking at old code and trying to figure out why things were done.

So ignore the MR - all these changes will be moved into other issues and committed one by one.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024