Report of issues that have not been dismissed

Created on 7 October 2024, 7 months ago

Problem/Motivation

On the reports at /admin/reports/editoria11y, dismissals and results seem to be completely separate. Editors have requested a list of issues that have not been dismissed so that they can more easily see issues that have not been addressed.

We tried to create a view using the views_custom_tables module that would be a definitive list of issues that had not been dismissed, but results and dismissals are in two separate tables, and there doesn't seem to be a key to join on.

The dashboard on each rendered page is able to hide results that have a dismissal, so it seems like there is enough data to do this within the report views, but I'm not seeing how. The tables editoria11y_results and editoria11y_dismissals each have their own view, I'm assuming this is because their isn't a shared result key in the editorially_dismissals table.

Steps to reproduce

Not applicable for a feature request.

Proposed resolution

Each result should have a unique ID that gets shared with the dismissals table to directly associate a dismissal with a specific result.

Remaining tasks

To be determined.

User interface changes

To be determined.

API changes

To be determined.

Data model changes

This would require a result key that could be used for a join in views.

✨ Feature request
Status

Active

Version

2.1

Component

Feature and test requests

Created by

πŸ‡ΊπŸ‡ΈUnited States joshuami Portland, OR

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @joshuami
  • πŸ‡ΊπŸ‡ΈUnited States itmaybejj

    If I am understanding you correctly -- that you want the dashboard views to not include dismissed results in the issue counts -- the views should already be behaving as you describe, provided people are using "Mark as checked and OK" to dismiss alerts they have reviewed. The mark OK button records the dismissal and decrements the number of issues found on that page in the results table.

    The "Hide alert" button only ignores it for the active user, so it remains visible in the result counts.

    The reason you are struggling with creating views is that individual result counts are not recorded at all -- the only thing recorded per page is a count of each type of issue that has not been marked as OK.

    If that is confusing -- you can control the ability to "mark OK" and "mark hidden (ignore)" by role -- so you could just turn off "mark hidden" on a site and only have one button. It's...possible that would be a less confusing default configuration for the module...

  • πŸ‡ΊπŸ‡ΈUnited States joshuami Portland, OR

    Ah... I see. We had not planned on allowing editors to mark OK for all as we kinda assume they will just clear results that are still an issue. (As I like to say to my teams, "editors are gonna edit." πŸ˜†)

    I can work with the current model by having our admins review items that editors have dismissed and mark them as okay when they have been reviewed.

    Thank you for the explanation!

  • πŸ‡ΊπŸ‡ΈUnited States itmaybejj

    Editors gonna edit indeed.

    I could add a routine to drop records of hiddens when something is marked OK. It makes sense to keep storing multiple hiddens against the same issue, but not a hidden and an OK...

    Of course, if I stop storing that, someone marking OK and then reverting the OK would purge those hiddens for everyone, which could be handy or confusing...

    ......this is why I'm so afraid to touch this part of the logic πŸ˜†

  • πŸ‡ΊπŸ‡ΈUnited States joshuami Portland, OR

    ......this is why I'm so afraid to touch this part of the logic πŸ˜†

    Indeed! πŸ˜†

    We rewrote much of the standard dashboard into an accessibility report that pulls in content based on an editor's group membership using views_custom_tables and some entity referencing from an entity ID relationship. Our end goal is to give editors a checklist of content to addressβ€”and maybe give them a cheery message when they've completed it all.

    Now that we understand the logic a bit better, we've decided to have an administrator report that shows content marked and okay by editors that can be reviewed monthly or quarterly to address editor's over-reporting content as okay when it isn't. This particular team has a really strong editor mentorship approach built into their governance.

    If you are interested, I could do a demo for you when I've finished up the approach.

  • πŸ‡ΊπŸ‡ΈUnited States itmaybejj

    I'd love to see it when it's ready; I'm all for making the default dashboard more useful, and for documenting ways to extend it.

Production build 0.71.5 2024