[PP-1] See if there's a less sweeping way to wire Composr Stager into Package Manager's services.yml

✨ Add Alpha level Experimental Package Manager module Needs review has landed

I added all the services to the file by making the service provider do it. This has resulted in adding

  UnitEnum:
    class: PhpTuf\ComposerStager\API\Process\Value\OutputTypeEnum

This shouldn't be a service... so this speaks to changing the approach here.

That looks great (except for the enum, but good to flush that out), net increase of nine lines except that underplays going from PHP to very repetitive YAML.

Also the service provider was overwriting and fixing the following service definiton:

-  PhpTuf\ComposerStager\API\FileSyncer\Service\FileSyncerInterface:
-    factory: ['@PhpTuf\ComposerStager\API\FileSyncer\Factory\FileSyncerFactoryInterface', 'create']

The factory no longer exists :) but the alias added by the service provider was overriding it...

One tiny nit but no particular objections. If the service provider was flawed then I agree it is better to remove it. The repetition in the services.yml file is unfortunate but at least it's straightforward and relatively short, thanks to autowiring.

Also, this means we can remove the dev dependency on symfony/config, if nothing else is using it. It was only ever there to support this (errors arising during container compilation were utterly inscrutable without it).

@phenaproxima symfony/config was already removed. It's was not necessary so it was removed the main issue.

Then ship it!

Committed/pushed to 11.x, thanks!

catch → closed merge request !9947

Automatically closed - issue fixed for 2 weeks with no activity.