Add bulk operations to subscriber view

Created on 4 October 2024, 6 months ago

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Feature request
Status

Active

Version

4.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @davps
  • Pipeline finished with Failed
    6 months ago
    #301326
  • I added a basic implementation and one operation "Delete subscriber" for example.

    We need to discuss what other operations are needed. Maybe new operations can be done in other tasks so as not to block the current one.

  • Pipeline finished with Failed
    6 months ago
    Total: 693s
    #301335
  • Pipeline finished with Success
    6 months ago
    Total: 686s
    #301347
  • 🇬🇧United Kingdom adamps

    Great I really like the idea.

    1) My main concern is that the fix adds a lot of lines of code - and already this module has way too much code to easily maintain. I would like to check if all this code is really necessary, or if there could be a simpler solution. I looked at Core, and I see that Node.php is similar to what you did, but Media and User entities are simpler.

    1. SubscriberBulkForm is identical to BulkForm so do we really need it?
    2. Media.php doesn't have anything in the routing file, and it uses the default DeleteMultipleForm without overriding. Do we definitely need these parts?
    3. Maybe we don't need to alter existing views in the update hook - some sites might even prefer not to have a bulk action.

    2) It would be great to have a test of the bulk function.

    Thanks

  • Pipeline finished with Canceled
    2 months ago
    Total: 92s
    #410071
  • Pipeline finished with Success
    2 months ago
    Total: 729s
    #410074
  • Status changed to Needs review 2 months ago
  • 1) My main concern is that the fix adds a lot of lines of code - and already this module has way too much code to easily maintain. I would like to check if all this code is really necessary, or if there could be a simpler solution. I looked at Core, and I see that Node.php is similar to what you did, but Media and User entities are simpler.

    @adamps, thanks for the comments. I reviewed the code and agree that it could have been made simpler. I have updated the current version of the code.

    Maybe we don't need to alter existing views in the update hook - some sites might even prefer not to have a bulk action.

    I think existing users should get the new changes as well as new users. I removed these changes to make it simpler.

    2) It would be great to have a test of the bulk function.

    Added.

  • 🇬🇧United Kingdom adamps

    Great thanks

  • Pipeline finished with Skipped
    2 months ago
    #417593
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024