findMatchingRedirect produces same hash when langcode specified

Created on 4 October 2024, 3 months ago

findMatchingRedirect inputs LanguageInterface::LANGCODE_NOT_SPECIFIED in the generateHash function even when you specify a different language, resulting in the same redirect being returned, even if you specify a different language.

🐛 Bug report
Status

Active

Version

1.0

Component

Code

Created by

achap 🇦🇺

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @achap
  • Pipeline finished with Failed
    3 months ago
    Total: 646s
    #300435
  • achap 🇦🇺

    Ran the test-only changes to confirm the test catches the bug. Looks like fixing this has caused knock on effects to other tests though. I'll look into it.

  • Pipeline finished with Success
    3 months ago
    Total: 228s
    #300476
  • achap 🇦🇺

    All the tests now seem to pass again except for this fail on the phpunit (next major) pipeline:

        1)
        Drupal\Tests\redirect\FunctionalJavascript\RedirectJavascriptTest::testRedirectUI
        Behat\Mink\Exception\ExpectationException: The string "Are you sure you
        want to delete the URL redirect from /web/non-existing?key=value to
        /web/node?" was not found anywhere in the HTML response of the current
        page.
    

    however looking at the pipelines from other commits it looks like its unrelated to my code.

Production build 0.71.5 2024