Contrib.social

[PP1] support configuration for xls/xslx serializer options from xls_serialization

Open on Drupal.org →
Created on 29 September 2024, 4 months ago

Problem/Motivation

Postponed as there are no exposed settings that make sense to exposed until 🐛 Make the formatValue filters configurable Needs work lands.

When 🐛 Make the formatValue filters configurable Needs work lands in xls_serialization module it would be nice to be able to configure this for data exports like the settings for csv are currently configurable.

Steps to reproduce

- Add xls_serialization (dependent on #3108301)
- Add views data export for xlsx format
- Try to configure strip tags and trim options

Proposed resolution

I have started a quick poc for testing the related issue locally - this follows how the csv settings are handled.

I note there is a todo in several places to improve how this is structure - given now there is a potential use case for settings on a separate serializer it would be time to investigate a cleaner implementation for the serializers exposing their settings / form to views data export. I have not spent any time thinking about how to achieve this.

Remaining tasks

Postponed on 🐛 Make the formatValue filters configurable Needs work

User interface changes

New options if format xls or xlsx is selected when xls_serialization is enabled.

📌 Task
Status

Postponed

Version

1.0

Component

Code

Created by

🇳🇿New Zealand ericgsmith

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @ericgsmith
  • Merge request !47Issue #3477661: Support strip html and trim settings for xls serializer → (Open) created by ericgsmith
  • Pipeline finished with Failed
    4 months ago
    Total: 311s
    #296374
  • Pipeline finished with Success
    4 months ago
    Total: 220s
    #296526
  • Comment 4 months ago →
    🇳🇿New Zealand ericgsmith
  • Pipeline finished with Failed
    4 months ago
    Total: 45s
    #313134
  • Comment 4 months ago →
    🇳🇿New Zealand ericgsmith

    Completely missed the first time around - but there are existing in the schema for xls settings - they are just not exposed in the UI anywhere.

    It would make sense to add these to the form as well - I am only specifically interested in this once the related issue lands in in xls serialization - so I do not plan to commit more time to this right at this moment.

  • Comment 3 months ago →
    🇳🇿New Zealand RoSk0 Wellington

    Looks good, apart from the fact that we need to duplicate schema and default configuration, but I guess this is a bigger problem and is out of scope here.

    RTBC++

  • Pipeline finished with Success
    2 months ago
    Total: 224s
    #348697
  • Comment 2 months ago →
    🇳🇿New Zealand ericgsmith

    Updating IS and changing to needs review now that change in xls_serialization landed

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024