- Issue created by @dcam
- πΊπΈUnited States dcam
I don't know why the previous major test is failing. I don't have a D9 test environment on this machine because all our sites are on D10. I'll have to check it on my personal time later.
- πΊπΈUnited States dcam
It was failing on D9 because I used the
clean_unique_id
Twig filter, which was introduced in D10.1. I initially changed it toclean_id
before remembering that the point of putting it in was to guarantee the description id's uniqueness. So I took out the filter entirely. If this is committed after the D11 upgrade issue - which I hope will remove D9 compatibility - then you might consider reverting those two commits to restore theclean_unique_id
filter. - πΊπΈUnited States dcam
I'm adding another change to the description wrapper. Currently the descriptions are wrapped in a
<p>
tag.The only time that the item descriptions are used is for image styles. But those descriptions are themed as an item list. The resulting
<ul>
are then wrapped by the<p>
, which is invalid HTML. It would be better if the descriptions were wrapped in a<div>
instead.