- Issue created by @chrisfromredfin
- Merge request !589update keyboardTest to wait for element that is failing in CI β (Open) created by chrisfromredfin
- πΊπΈUnited States chrisfromredfin Portland, Maine
Turns out this runs on 11.0.4 just fine, but fails on 11.0.x - these are the only 6 commits since:
- #3474108 β by smustgrave, tomomi: Replace eslint-plugin-jquery with eslint-plugin-no-jquery
- #3465154 β by yujiman85, n-m-daz, nod_: Update run-tests.sh help output to match current test organization
- #3470114 β by quietone, smustgrave: Change string 'Modules to enable' that are not in comments
- #3471949 β by mstrelan: Allow passing MarkupInterface to AssertContentTrait::setRawContent
- #3473214 β by mstrelan: Stop passing ints to DateTimePlus::createFromFormat and DrupalDateTime::createFromFormat
- #3302833 β by akhil babu, b_sharpe, alexpott, oily, smustgrave: Improve PluginNotFound exception to include possible shorthand action IDs
- πΊπΈUnited States chrisfromredfin Portland, Maine
That might be wrong (above). I was using drupal-mrn.dev but more has been committed to 11.x-dev. I think we'll need to try and git bisect and run the tests and try to figure out which commit caused the issue.
- π¬π§United Kingdom jonathan1055
Turns out this runs on 11.0.4 just fine, but fails on 11.0.x
If you wanted to prove this in the pipeline, you can add:
composer (next major): variables: DRUPAL_CORE: '11.0.4'
to temporarily fix the core version. It would be good to see the nightwatch test pass in a pipeline here. Then we know exactly what we are dealing with.
- π¬π§United Kingdom jonathan1055
That was interesting. I ran it with core 11.0.4 at the Nightwatch version was 2.4.2 not 3.7.0 which we get with 11.x-dev
https://git.drupalcode.org/issue/project_browser-3477343/-/jobs/2883174 - π¬π§United Kingdom jonathan1055
I've done another test, using 11.0.x-dev for the Drupal core version in 'Next Major'. This shows the actual versions is 11.0.5-dev in the Nightwatch job, and as that is running Nightwatch 2.4.2 it also needs the legacy driver. The tests end green
https://git.drupalcode.org/issue/project_browser-3477343/-/pipelines/296863To me, this shows that the problem is caused by the differences between Core 11.0.x-dev / Nightwatch 2.4.2 and Core 11.x-dev / Nightwatch 3.7.0. Apologies is that was obvious, but I wanted to check the comment in #4 "but fails on 11.0.x" as that is not strictly true. Hope this helps. You can revert my last commit when you next want to test at 11.x-dev
- πΊπΈUnited States chrisfromredfin Portland, Maine
Oh wonderful, I think this is actually what we want - the 11.0.x-dev to be our test base. Really appreciate you jumping in, @jonathan1055!
- π¬π§United Kingdom jonathan1055
Pleased to help.
What about your PHPUnit jobs? They currently pass at 11.x-dev with the new selenium driver
https://git.drupalcode.org/project/project_browser/-/jobs/2882356So the question is, do you want those to stay at 11.x-dev or bring them back also to align with Nightwatch at 11.0.x-dev? Let me know you preference and I can adjust your template, becauase temporarily I skipped phpunit (knowing it would fail the way I set up the demonstration of Nightwatch)