- Issue created by @StryKaizer
- Merge request !170Issue #3477020: Search api DB does not support nested conditionGroups β (Merged) created by StryKaizer
- π¦πΉAustria drunken monkey Vienna, Austria
drunken monkey β made their first commit to this issueβs fork.
- π¦πΉAustria drunken monkey Vienna, Austria
Thanks a lot for posting this issue and the MR fixing it!
Seems very sensible to me. The fact that tags on nested condition groups are ignored is clearly an oversight.
However, your code would still ignore tags nested more than one level deep (even though there is currently no use case for that). Instead, I suggest adding a new helper method and just calling it recursively β I think that would also make the code a bit cleaner.
Iβm also adding a regression test.Updated the MR, please test/review.
- π¦πΉAustria drunken monkey Vienna, Austria
(Test failure is due to π Fix test failures against Drupal 11 Active .)
- π§πͺBelgium StryKaizer Belgium
Tested and fixes the issue.
Recursion is of course the way to goThanks for looking into this so quickly Thomas!
This will make a new release for Facets 3.x go much smoother ;) - π¦πΉAustria drunken monkey Vienna, Austria
Good to hear, thanks for reporting back so quickly!
Merged. Thanks again! -
drunken monkey β
committed eba68131 on 8.x-1.x authored by
strykaizer β
Issue #3477020 by strykaizer, drunken monkey: Fixed bug in database...
-
drunken monkey β
committed eba68131 on 8.x-1.x authored by
strykaizer β
Automatically closed - issue fixed for 2 weeks with no activity.