component: navbar/page-header "color_mode"

Created on 25 September 2024, about 2 months ago

Problem/Motivation

"color_mode" is used in the following but doesn't seem to be used for anything:

component: navbar
component: page-header

E.g.
navbar.twig

{% set color_mode = color_mode ? ['navbar-' ~ color_mode] : [] %}

Example results in

class="navbar-dark"

or...

class="navbar-light"

both classes don't exist anywhere,

Proposed resolution

Remove those references, or replace with something like

data-bs-theme="dark" 
data-bs-theme="light" 

EX:

<nav class="navbar bg-primary" data-bs-theme="dark">
  <!-- Navbar content -->
</nav>

As mentioned in bootstrap 5.3

https://getbootstrap.com/docs/5.3/components/navbar/

https://getbootstrap.com/docs/5.3/customize/color-modes/

Remaining tasks

  • ✅ File an issue about this project
  • ❌ Addition/Change/Update/Fix to this project
  • ❌ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Code review from 1 Varbase core team member
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes and Update Helper on new feature change/addition
  • ❌ Release

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • N/A
📌 Task
Status

Active

Version

2.0

Component

Code

Created by

🇺🇸United States duntuk

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.71.5 2024