Move invisible element warning from modal alert to main panel

Created on 23 September 2024, 5 days ago

Problem/Motivation

A modal alert is triggered for every error or warning that (the module thinks) is thrown by an invisible element. Each modal must be dismissed individually to continue working. This is incredibly frustrating.

Steps to reproduce

Have a page with warnings/errors triggered by elements the module thinks are invisible.
Hit "Next" to go to one of these errors.
Have the whole window frozen by the alert modal until it is dismissed.

Proposed resolution

The alert modals should be removed. Instead, these messages should appear in the main panel at bottom right.

Remaining tasks

Confirm that the proposed resolution is acceptable.
Implement the proposed resolution

User interface changes

Main panel will get slightly bigger to leave space for the message, so that the Previous/Next buttons do not move around while clicking through warnings.

API changes

None.

Data model changes

None, I think?

💬 Support request

Status

Active

Version

2.1

Component

Feature and test requests

Created by

🇺🇸United States Lanny Heidbreder

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @Lanny Heidbreder
Comment 5 days ago →
🇺🇸United States itmaybejj
Oh I like this idea.

I need to rewrite that whole part of the code as part of the CKEditor integration rewrite, so I'll add this to the queue for that.
Comment 5 days ago →
🇺🇸United States itmaybejj
Comment 5 days ago →
🇺🇸United States itmaybejj
Oh one last note -- ideally, if you are able to add JS to the site, you can get rid of these alerts altogether by automatically opening elements to reveal the hidden content with the error before Editoria11y runs the hidden check.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024