- Issue created by @daffie
- Status changed to Needs review
3 months ago 8:16am 20 September 2024 The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs work
27 days ago 2:15pm 22 November 2024 - 🇬🇧United Kingdom alexpott 🇪🇺🌍
Not sure how this is going to be maintained unless mongo is in core :)
Maybe it is possible to add a listener in kernel tests to ensure that the entity schema is installed before creating a field on it?
- 🇳🇱Netherlands daffie
Maybe it is possible to add a listener in kernel tests to ensure that the entity schema is installed before creating a field on it?
I have added a listener to the kerneltestbase class and found a new instance were an entity schema was not created: Drupal\Tests\layout_builder\Kernel\ConfigActionsTest. The test was added a week ago in ✨ Allow recipes to enable layout builder Needs work .
@alexpott: Thank you for the review and your suggestion how to make it better.
- 🇮🇹Italy mondrake 🇮🇹
This is very nice regardless of MongoDb in its enforcing proper dependencies of actions.
Is it possible to add a test for the new subscriber? More comments inline in the MR.
- 🇳🇱Netherlands daffie
All remarks on the MR by @mondrake have been addressed.
A test has been added for the new field storage create check subscriber.
Back to NR.@mondrake: Thank you for the review.
- 🇳🇱Netherlands daffie
Applied the requested changes.
@mondrake: Thanks for the review.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
@daffie the event listener turned out great! Think we need to make a small adjustment for non core tests and trigger a deprecation until Drupal 12. See MR for suggestion for how to do this.
- 🇳🇱Netherlands daffie
The requested warning has been added for non-core tests. Back to NR.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
@daffie the changes look great. Will commit once this is rtbc again
-
alexpott →
committed 7f543411 on 11.x
Issue #3475719 by daffie, mondrake, alexpott: Set entity schema...
-
alexpott →
committed 7f543411 on 11.x