Contrib.social

Coding Standard issues

Open on Drupal.org →
Created on 17 September 2024, 7 months ago

Problem/Motivation

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .

FILE: .../web/modules/custom/wpf/src/Controller/ImageStyleDownloadController.php
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------
11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\image\Controller\ImageStyleDownloadController.
48 | ERROR | [x] Expected 1 space after "="; 2 found
72 | ERROR | [x] Expected one space after the comma, 0 found
97 | ERROR | [x] Expected one space after the comma, 0 found
-----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/wpf/src/ImageFactory.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 13 ERRORS AND 1 WARNING AFFECTING 12 LINES
--------------------------------------------------------------------------------------------------------------------------------
13 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface.
123 | ERROR | [ ] Parameter $entity_type_manager is not described in comment
123 | ERROR | [ ] Parameter $file_system is not described in comment
123 | ERROR | [ ] Parameter $mime_type_guesser is not described in comment
174 | WARNING | [x] 'Todo: prepare function for imagick toolkit.' should match the format '@todo Fix problem X here.'
312 | ERROR | [x] @inheritDoc found. Did you mean {@inheritDoc}?
348 | ERROR | [x] Expected 1 blank line after function; 2 found
352 | ERROR | [x] @inheritDoc found. Did you mean {@inheritDoc}?
373 | ERROR | [x] @inheritDoc found. Did you mean {@inheritDoc}?
387 | ERROR | [x] @inheritDoc found. Did you mean {@inheritDoc}?
405 | ERROR | [x] Parameter comment must be on the next line
407 | ERROR | [ ] Description for the @return value must be on the next line
414 | ERROR | [x] Comments may not appear after statements
417 | ERROR | [x] Comments may not appear after statements
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/wpf/src/ImageFactoryInterface.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface.
7 | WARNING | [x] Unused use statement
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/wpf/wpf.services.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
16 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: .../web/modules/custom/wpf/wpf.module
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
40 | WARNING | Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements
| | hook_foo_BAR_ID_bar() for block templates."
-------------------------------------------------------------------------------------------------------------------------------------------------

Steps to reproduce

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Active

Version

1.2

Component

Code

Created by

🇵🇪Peru alyaj2a

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024