Destination Param causes Leaked Metadata

Next I tried this with a Standard Drupal Site install with the only extra module being SAML Authentication. I created a page with a login link with a destination back to /node in content (/saml/login?destination=/node) and was still getting the leaked metadata warning.

That's very interesting. That really points to this module doing something wrong (as opposed to the 'fault' being in code that is being called in contrib code by e.g. a hook, as is the case in #3232577: Code leaked cacheability metadata → ). Thank you for checking.

I should really reproduce this and check. (And also check, what exactly the 📌 Exception in EarlyRenderingControllerWrapperSubscriber is a DX nightmare, remove it Needs work fix is that went into Drupal Core after nine years of stalling, and how it affects the necessity for this warning.)

("when I get the time" (TM))

This was reported in another issue and I made a MR for it: https://www.drupal.org/project/samlauth/issues/3486925 🐛 Cacheability Metadata Leakage Error on SAML Login with Samlauth and r4032 Redirect Module Active

Thank you, the patch in the other issue resolves my problem.

Closing issue in favor of https://www.drupal.org/project/samlauth/issues/3486925 🐛 Cacheability Metadata Leakage Error on SAML Login with Samlauth and r4032 Redirect Module Active .