Code Standards Cleanup for 4.x

Created on 15 September 2024, 3 months ago

I found code styling issues in the module while checking a site using this module with CodeSniffer.
These should be fixed to bring the module's code up to current Drupal standards.

πŸ“Œ Task
Status

Needs review

Version

4.0

Component

Code

Created by

πŸ‡ΊπŸ‡¦Ukraine olmyr Ukraine, Kharkiv

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @olmyr
  • Pipeline finished with Success
    3 months ago
    Total: 307s
    #283894
  • Status changed to Needs review 3 months ago
  • πŸ‡ΊπŸ‡¦Ukraine olmyr Ukraine, Kharkiv
  • πŸ‡ΊπŸ‡ΈUnited States emptyvoid

    Noted when running Update Status Drupal 11 compliance pass the following issues identified from code review.

    Are the committed changes to address the following?

    Acquia Connector,  4.0.9
    Scanned on Wed, 10/09/2024 - 14:09
    
    FILE:
    modules/contrib/acquia_connector/tests/src/Kernel/AcquiaConnectorTestBase.php
    
    STATUS         LINE                           MESSAGE                           
    --------------------------------------------------------------------------------
    Ignore         127  Call to deprecated method renderPlain() of class            
                        Drupal\Core\Render\Renderer. Deprecated in drupal:10.3.0 and
                        is removed from drupal:12.0.0. Use                          
                        Drupal\Core\Render\RendererInterface::renderInIsolation()   
                        instead.                                                    
    --------------------------------------------------------------------------------
    
    FILE:
    modules/contrib/acquia_connector/tests/src/Kernel/Client/ClientFactoryTest.php
    
    STATUS         LINE                           MESSAGE                           
    --------------------------------------------------------------------------------
    Ignore         22   Call to deprecated method getConfig() of class              
                        GuzzleHttp\Client: Client::getConfig will be removed in     
                        guzzlehttp/guzzle:8.0.                                      
    --------------------------------------------------------------------------------
    
    FILE: modules/contrib/acquia_connector/tests/src/Kernel/HelpIntegrationTest.php
    
    STATUS         LINE                           MESSAGE                           
    --------------------------------------------------------------------------------
    Ignore         42   Call to deprecated method renderPlain() of class            
                        Drupal\Core\Render\Renderer. Deprecated in drupal:10.3.0 and
                        is removed from drupal:12.0.0. Use                          
                        Drupal\Core\Render\RendererInterface::renderInIsolation()   
                        instead.                                                    
    --------------------------------------------------------------------------------
    
    
Production build 0.71.5 2024