Contrib.social

Disallowing a pull in PULL_PRESAVE does not stop the entity from being created.

Open on Drupal.org →
Created on 12 September 2024, 7 months ago

Problem/Motivation

The PULL_PRESAVE description says: "Final chance for subscribers to prevent creation or alter a Drupal entity
during pull."
I have found this is not the case and that disallowing a pull does not stop the entity from being created.
It is clear why this happens from L585-595 of Drupal\salesforce_mapping\Entity\MappedObject.php

Steps to reproduce

  • Trigger a pull on a new item.
  • Interrupt the pull in the PULL_PRESAVE event using $event->disallowPull().
  • The entity will be created even though the pull is disallowed.

    • Proposed resolution

    I have made a patch that will check if the pull is disallowed, and if so it will not save the entity or the mapped_object.

    Remaining tasks

    Review and test

🐛 Bug report
Status

Active

Version

5.1

Component

salesforce_mapping.module

Created by

scambler

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @scambler
  • Comment 7 months ago →
    scambler

    Patch:

  • Status changed to Needs review 3 months ago
  • Comment 3 months ago →
    scambler
  • Comment 3 months ago →
    🇪🇸Spain alexortega_98 Seville

    The pull is already done by this point, that's why disallowPull() doesn't work. Try using PULL_PREPULL event instead, it happens before PULL_PRESAVE, and allows you to use disallowPull() and therefore, it won't get saved into Drupal.

    You can have a look to SalesforceExampleSubscriber.php file, just inside salesforce_example module that is included in the salesforce module, and look for the pullPrepull() function, you have a nice example there.

  • Status changed to Closed: works as designed about 1 month ago
  • Comment about 1 month ago →
    🇺🇸United States AaronBauman Philadelphia
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024