TypeError passing FormattableMarkup instead of string

Created on 12 September 2024, 4 months ago

Problem/Motivation

TypeError: PNX\Prometheus\Metric::__construct(): Argument #3 ($help) must be of type string, Drupal\Core\StringTranslation\TranslatableMarkup given, called in /data/app/modules/contrib/prometheus_webform/src/Plugin/MetricsCollector/SubmissionsCollector.php on line 61 in PNX\Prometheus\Metric->__construct() (line 46 of /data/vendor/previousnext/php-prometheus/src/Metric.php).

Steps to reproduce

Proposed resolution

Cast $this->getDescription() to string. Arguably the constructor could be updated to accept string|\Stringable.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Needs work

Version

1.0

Component

Code

Created by

🇦🇺Australia mstrelan

Live updates comments and jobs are added and updated live.

Merge Requests

!3TypeError passing FormattableMarkup instead of string
Open
🇦🇺Australia mstrelan
updated 4 months ago

Comments & Activities

Issue created by @mstrelan
Merge request !3Cast description to string → (Open) created by mstrelan
Status changed to Needs review 4 months ago1:47am 12 September 2024
Comment 4 months ago →
🇦🇺Australia mstrelan
Pipeline finished with Failed
4 months ago
Total: 141s
#280659
Status changed to Needs work 4 months ago1:55am 12 September 2024
Comment 4 months ago →
🇦🇺Australia acbramley
I think string|\Stringable makes the most sense here.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024