- Issue created by @mstrelan
- Status changed to Needs review
6 months ago 1:47am 12 September 2024 - Status changed to Needs work
6 months ago 1:55am 12 September 2024 - 🇦🇺Australia mstrelan
I'm not sure about #4.
PNX\Prometheus\Metric
can't do anything special with Stringable objects we pass to it, so it makes sense to limit it to only primitive strings. What if instead we cast to string in\Drupal\prometheus_exporter\Plugin\BaseMetricsCollector::getDescription
? That would mean the existing return type in\Drupal\prometheus_exporter\Plugin\MetricsCollectorInterface::getDescription
is valid and we don't have to mess around with types in multiple places. - 🇦🇺Australia mstrelan
Moved to Prometheus Exporter queue since any Drupal solution would apply to more than just Prometheus Webform, and any library solution can be discussed there. Wonder what that will do with the existing issue fork.
- 🇦🇺Australia mstrelan
mstrelan → changed the visibility of the branch 3473714-typeerror to hidden.
- 🇦🇺Australia mstrelan
Both the label and description are usually FormattableMarkup objects, or sometimes strings. Let's leave the library to require strings and do the casting on the Drupal side.
-
acbramley →
committed 92082a49 on 2.x authored by
mstrelan →
Issue #3473714 by mstrelan, acbramley: TypeError passing...
-
acbramley →
committed 92082a49 on 2.x authored by
mstrelan →
Automatically closed - issue fixed for 2 weeks with no activity.