Correct by reference @return in DocBlock

Created on 11 September 2024, 4 months ago

Updated 12 September 2024, 4 months ago

Problem/Motivation

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig .

FILE: .../web/modules/custom/genpass/src/Plugin/Validation/Constraint/GenpassModeConstraint.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
21 | ERROR | [x] Missing class doc comment
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/genpass/src/Plugin/Validation/Constraint/GenpassModeConstraintValidator.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------
84 | ERROR | [x] Array indentation error, expected 8 spaces but found 10
85 | ERROR | [x] Array indentation error, expected 8 spaces but found 10
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/genpass/src/Plugin/Action/UserSetRandomPassword.php
---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
21 | ERROR | [x] Missing class doc comment
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------

FILE: .../web/modules/custom/genpass/genpass.module
----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------
224 | ERROR | Type hint "array" missing for $form
----------------------------------------------------------------------------

FILE: .../web/modules/custom/genpass/tests/modules/genpass_test/genpass_test.module
------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------
83 | ERROR | [x] Expected "array" but found "&array" for function return type
225 | ERROR | [x] Expected "array" but found "&array" for function return type
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------

Steps to reproduce

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig .

Proposed resolution

Remaining tasks

✅ File an issue
➖ Addition/Change/Update/Fix
➖ Testing to ensure no regression
➖ Automated unit testing coverage
➖ Automated functional testing coverage
➖ UX/UI designer responsibilities
➖ Readability
➖ Accessibility
➖ Performance
➖ Security
➖ Documentation
➖ Code review by maintainers
➖ Full testing and approval
➖ Credit contributors
➖ Review with the product owner
➖ Release notes snippet
❌ Release

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task

Status

Fixed

Version

2.1

Component

Code

Created by

🇵🇪Peru alyaj2a

Live updates comments and jobs are added and updated live.

Merge Requests

!28Correct by reference @return in DocBlock
Merged
🇵🇪Peru alyaj2a
updated 4 months ago

Comments & Activities

Issue created by @alyaj2a
Comment 4 months ago →
🇵🇪Peru alyaj2a
Merge request !28[#3473696] Correct by reference @return in DocBlock. → (Merged) created by alyaj2a
Pipeline finished with Success
4 months ago
Total: 262s
#280504
Issue was unassigned.
Status changed to Needs review 4 months ago10:22pm 11 September 2024
Comment 4 months ago →
🇵🇪Peru alyaj2a
First commit to issue fork.
Comment 4 months ago →
System Message

elc → committed 29f5730c on 2.1.x authored by alyaj2a →
[#3473696] Correct by reference @return in DocBlock.
Status changed to Fixed 4 months ago3:42am 12 September 2024
Comment 4 months ago →
🇦🇺Australia elc
Renaming to be relevant change.
Comment 4 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024