Coding standard issues

Working

Hi @xenophyle

I worked on this and solved all the PHPCS issues. I also reverted back the removal of translation of form elements (t()) in the mailchimp.module file. Since i added back the t(), it is showing warning in phpcs pipeline but rest all the errors are solved.

The phpunit tests are failing and are giving the error:
Unable to install modules: module 'mailchimp' is incompatible with this version of Drupal core.

Can you please look into it?
Thanks,
Akul

Hi @xenophyle

I tried solving the error. The phpcs errors have been taken care of but the PHPUnit error still persists -

Unable to install modules: module 'mailchimp' is incompatible with this version of Drupal core.

The error is occurring because the module is compatible with Drupal version 10 while the test cases have been updated to Drupal 11 which the module is incompatible with. The tests need to be made compatible with the module.

Can you please look into it?
Thanks,
Akul

Hi @xenophyle

The last phpcs errors have been taken care of but the PHPUnit error still persists -

Unable to install modules: module 'mailchimp' is incompatible with this version of Drupal core.

The error is occurring because the module is compatible with Drupal version 10 while the test cases have been updated to Drupal 11 which the module is incompatible with. The tests need to be made compatible with the module.

Can you please look into it?
Thanks,
Akul

Akul, the tests in this branch, 2.x, are now targeting D10. I notice there are 5 failing phpunit tests, most of which will be fixed by the solution to 🐛 After upgrading to Mailchimp 2.2.5, failure to get lists results in a fatal error on login Active .

This issue is dedicated to solving the PHPCS problems in the module.
Should I try to solve the PHPUnit tests here as well or a new issue is to be created for the same?

@akulsaxena, yes, you are right!

Automatically closed - issue fixed for 2 weeks with no activity.