Remove @todo in REST resource plugin

Created on 9 September 2024, 5 months ago
  /**
   * {@inheritdoc}
   *
   * @todo This should be 'protected', but the Drupal core REST module test
   * base improperly overrides it to be public which requires that we also use
   * the wrong visibility here. Restore 'protected' when core gets fixed.
   */
  public function setUp(): void {
    parent::setUp();

    $auth = isset(static::$auth) ? [static::$auth] : [];
    $this->provisionResource([static::$format], $auth);
  }

This was finally fixed in Drupal 10+ by the core issue πŸ› Ensure correct signature for setUp(), tearDown(), setUpBeforeClass(), and assertPostConditions() methods Fixed so we can now fix it in Ip2Country. Because branch 2.0.x still supports Drupal 9, this can only be done in Ip2Country 2.1.x.

πŸ“Œ Task
Status

Fixed

Version

2.1

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States tr Cascadia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024