- Issue created by @phenaproxima
- Status changed to Needs review
2 months ago 3:16am 9 September 2024 - Status changed to Needs work
2 months ago 10:13am 9 September 2024 - π¦πΊAustralia darvanen Sydney, Australia
Well it passes manual testing. I don't really understand how the test is supposed to work? It seems to be picking up the web root of the project it's being run in:
Failed asserting that two strings are identical. Expected :'' Actual :'web' Failed asserting that two strings are identical. Expected :'web' Actual :'web/web'
- π¦πΊAustralia darvanen Sydney, Australia
The unit test you supplied initially works alright, should we just swap that out?
- Status changed to Needs review
2 months ago 12:25pm 9 September 2024 - πΊπΈUnited States phenaproxima Massachusetts
Yeah - turns out that my test logic was wrong there. That's what happens when you quickly dash off an MR like this at 11 o'clock at night. :) Should be fixed now.
- Status changed to RTBC
2 months ago 10:54pm 9 September 2024 -
darvanen β
committed d535c204 on 2.x authored by
phenaproxima β
Issue #3472953 by phenaproxima, darvanen: Determine the web root...
-
darvanen β
committed d535c204 on 2.x authored by
phenaproxima β
- Status changed to Fixed
2 months ago 10:54pm 9 September 2024 - Status changed to Needs work
2 months ago 11:08pm 9 September 2024 - π¦πΊAustralia darvanen Sydney, Australia
Uh... now there are no tests, I'll put the unit test back in (and remove web_root from the settings form which I forgot to do). That's what I get for only checking the test results, not the code /facedesk.
-
darvanen β
committed 109c030d on 2.x
Issue #3472953 by phenaproxima, darvanen: Determine the web root...
-
darvanen β
committed 109c030d on 2.x
- Status changed to Fixed
2 months ago 11:35pm 9 September 2024 - π¦πΊAustralia darvanen Sydney, Australia
That's better, thanks @phenaproxima
Automatically closed - issue fixed for 2 weeks with no activity.