- Issue created by @tr
- πΊπΈUnited States tr Cascadia
The issues that introduced the @codingStandardsIgnore directives are old and were tested under Drupal CI. All that test output is now gone so I can't tell what the exact motivation was to introduce those directives. Since I really really would like to disable only specific sniffs, the first step is to find out which sniffs are failing, and the easiest way to do this is to just first remove all the @codingStandardsIgnore statements, see what coding standards warnings are generated, then fix them from scratch.
With our ever-changing coding standards, we may find out there are more issues or there are some that don't need to be ignored anymore. Let's find out.
- Merge request !71First let's remove @codingStandards to see what the issues are. β (Merged) created by tr
- πΊπΈUnited States tr Cascadia
The errors to be ignored are as follows. I have verified that we really do want to be ignoring all of these, and now we know exactly what we're ignoring.
-------------------------------------------------------------------------------- FILE: ...builds/project/rules/web/modules/custom/rules/src/Logger/RulesDebugLog.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES -------------------------------------------------------------------------------- 129 | WARNING | Do not concatenate strings to translatable strings, they | | should be part of the t() argument and you should use | | placeholders (Drupal.Semantics.FunctionT.ConcatString) 142 | WARNING | Only string literals should be passed to t() where possible | | (Drupal.Semantics.FunctionT.NotLiteralString) 183 | WARNING | Only string literals should be passed to t() where possible | | (Drupal.Semantics.FunctionT.NotLiteralString) 208 | WARNING | Only string literals should be passed to t() where possible | | (Drupal.Semantics.FunctionT.NotLiteralString) -------------------------------------------------------------------------------- FILE: ...t/rules/web/modules/custom/rules/src/Drush/Commands/RulesDrushCommands.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 309 | WARNING | Line exceeds 80 characters; contains 82 characters | | (Drupal.Files.LineLength.TooLong) -------------------------------------------------------------------------------- FILE: ...ules/web/modules/custom/rules/src/Context/ContextHandlerIntegrityTrait.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 9 | WARNING | [x] Unused use statement | | (Drupal.Classes.UnusedUseStatement.UnusedUse)
- Status changed to Fixed
8 months ago 5:37am 15 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.