- Issue created by @tedbow
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
wim leers β made their first commit to this issueβs fork.
- Assigned to tedbow
- Status changed to Needs review
4 months ago 10:35am 3 September 2024 - Status changed to RTBC
4 months ago 4:04am 4 September 2024 - πΊπΈUnited States tedbow Ithaca, NY, USA
@wim leers thanks
This looks good for now. I just looked quickly if what was added makes sense. I didn't try to think about what more could be explained.
I fixed phpcs and I think we should just commit it(if tests pass) as these additions would have helped. Can always make it better later.
- Assigned to wim leers
- πΊπΈUnited States tedbow Ithaca, NY, USA
Since I won't be around to see if the tests pass assigning back to @wim leers to commit. Will check tomorrow I can commit if needed
- Assigned to tedbow
- Status changed to Needs review
4 months ago 10:35am 4 September 2024 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
@tedbow you didn't approve the MR π β¦
-
tedbow β
committed a3b624c1 on 0.x authored by
wim leers β
Issue #3471302 by wim leers, tedbow: Add docs to PropSourceEndpointTest
-
tedbow β
committed a3b624c1 on 0.x authored by
wim leers β
- Status changed to Fixed
4 months ago 12:40pm 4 September 2024 - Issue was unassigned.
Automatically closed - issue fixed for 2 weeks with no activity.