Some IsbnToolsService methods do not respect the expected return typehints

Created on 30 August 2024, 3 months ago

After upgrading to Drupal 10.3.2 and using PHP 8.2, we are getting the following error:

TypeError  Drupal\isbn\IsbnToolsService::convertIsbn10to13(): Return value must be of type ?string, none returned.

This is because the method returns void instead of NULL when the ISBN passed is not valid.

Same behavior can be shown in other methods like convertIsbn13to10() or format().

Run this code: \Drupal::service('isbn.isbn_service')->convertIsbn10to13('foo');

Observe the Type Error

🐛 Bug report

Status

Closed: outdated

Version

1.0

Component

Code

Created by

🇪🇸Spain plopesc Valladolid

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @plopesc
Status changed to Closed: outdated 3 months ago2:15pm 30 August 2024
Comment 3 months ago →
🇪🇸Spain plopesc Valladolid
Found that this is already fixed in HEAD code.

Sorry for the noise
Comment 3 months ago →
🇳🇱Netherlands megachriz
Okay, thanks for checking.

I was going to say if this was perhaps already handled in 🐛 IsbnToolsService::format() throws php error when tool formatting fails Fixed .

I hope to create a new release in a few weeks. I'm first focussing on getting other projects ready for Drupal 11.

Production build 0.71.5 2024