Created on 30 August 2024, 7 months ago
Updated 3 September 2024, 7 months ago

Problem/Motivation

TBD

Proposed resolution

TBD

Remaining tasks

User interface changes

API changes

Data model changes

Feature request
Status

Active

Version

2.2

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @s_leu
  • Merge request !26Open links in modal → (Open) created by s_leu
  • Pipeline finished with Failed
    7 months ago
    Total: 523s
    #268882
  • Pipeline finished with Failed
    7 months ago
    Total: 495s
    #269077
  • Pipeline finished with Failed
    7 months ago
    Total: 495s
    #269182
  • Pipeline finished with Failed
    7 months ago
    Total: 527s
    #271651
  • Pipeline finished with Failed
    7 months ago
    Total: 471s
    #272025
  • Pipeline finished with Failed
    7 months ago
    Total: 603s
    #272053
  • Pipeline finished with Failed
    7 months ago
    Total: 381s
    #272072
  • Pipeline finished with Canceled
    7 months ago
    Total: 434s
    #272165
  • Pipeline finished with Failed
    7 months ago
    Total: 806s
    #272167
  • Pipeline finished with Failed
    7 months ago
    Total: 524s
    #272304
  • Pipeline finished with Canceled
    7 months ago
    Total: 87s
    #274227
  • Pipeline finished with Failed
    7 months ago
    Total: 606s
    #274231
  • Pipeline finished with Failed
    7 months ago
    Total: 703s
    #274262
  • Pipeline finished with Failed
    7 months ago
    Total: 440s
    #274276
  • Pipeline finished with Failed
    7 months ago
    Total: 442s
    #274307
  • Status changed to Needs review 7 months ago
  • Initial MR is ready for review/testing

  • s_leu changed the visibility of the branch 3391226_3371633_3471130_combined to hidden.

  • 🇺🇦Ukraine danmer

    Hello @s_leu, I tried to apply the patch but faced an issue, so I slightly updated it. Can you please check this patch?

  • 🇮🇹Italy tanc Italy

    @s_leu I'm testing your MR and most of it works well except the link doesn't open in a modal unless the "CSS classes" Advanced Link option is enabled.

    Without that enabled it produces a link that looks like this:

    <a href="/node/7" data-entity-type="node" data-entity-uuid="1f581338-2a63-451d-9cbd-45606aa0919b" data-entity-substitution="modal" data-dialog-type="modal" data-dialog-options="{&quot;width&quot;:&quot;80%&quot;}">Test</a>

    I can also see the dialog.ajax.js library is correctly loaded. But clicking the link does not open it in a dialog, it just opens normally.

    If I enable the "CSS classes" Advanced Link option and resave the link then the link correctly has the use-ajax class applied and opens correctly in a modal.

    So my only suggestion would be to find a way to allow the "Open in modal" option to work without requiring the "CSS classes" option if possible.

  • 🇮🇹Italy tanc Italy

    @danmer if you provide an interdiff and some explanation of your changes it would be a lot easier to understand what you've done

Production build 0.71.5 2024