- Issue created by @s_leu
- Merge request !27Draft: Issue #3471130: Working use ajax class and loading of default value for open... → (Closed) created by s_leu
- Status changed to Needs review
7 months ago 8:26am 5 September 2024 s_leu → changed the visibility of the branch 3391226_3371633_3471130_combined to hidden.
- 🇺🇦Ukraine danmer
Hello @s_leu, I tried to apply the patch but faced an issue, so I slightly updated it. Can you please check this patch?
- 🇮🇹Italy tanc Italy
@s_leu I'm testing your MR and most of it works well except the link doesn't open in a modal unless the "CSS classes" Advanced Link option is enabled.
Without that enabled it produces a link that looks like this:
<a href="/node/7" data-entity-type="node" data-entity-uuid="1f581338-2a63-451d-9cbd-45606aa0919b" data-entity-substitution="modal" data-dialog-type="modal" data-dialog-options="{"width":"80%"}">Test</a>
I can also see the
dialog.ajax.js
library is correctly loaded. But clicking the link does not open it in a dialog, it just opens normally.If I enable the "CSS classes" Advanced Link option and resave the link then the link correctly has the
use-ajax
class applied and opens correctly in a modal.So my only suggestion would be to find a way to allow the "Open in modal" option to work without requiring the "CSS classes" option if possible.
- 🇮🇹Italy tanc Italy
@danmer if you provide an interdiff and some explanation of your changes it would be a lot easier to understand what you've done