Contrib.social

Config Enforce form element makes View Style form unusable

Open on Drupal.org →
Created on 28 August 2024, about 1 year ago

Problem/Motivation

With Config Enforce enabled, when configuring a Views Style Plugin ($form_id == 'views_ui_edit_display_form'), the form ends up getting cut off by the dialog button set ("Apply", "Cancel").

Steps to reproduce

  1. Edit a View configuration.
  2. Click on the Format > Settings link
  3. Observe the CE form element at the top of the Ajax form
  4. Scroll to the bottom of the form
  5. Observe that the last form element is cut off by the dialog buttons
  6. Set display: none for the CE form element using browser inspection tools
  7. Observe that the last form element is now visible above the dialog buttons

Proposed resolution

Add views_ui_edit_display_form to the denylist in config_enforce_config_enforce_form_denylist().

Note that the config object related to this form (views.view.foo) is the same as the View form itself (view_edit_form). Since displaying the CE element here is redundant, removing it is an improvement from the stand-point of clarity anyway.

Remaining tasks

  • Add views_ui_edit_display_form to the denylist in config_enforce_config_enforce_form_denylist().

User interface changes

As noted above.

API changes

N/A

Data model changes

N/A

🐛 Bug report
Status

Needs review

Version

1.0

Component

User interface

Created by

🇨🇦Canada ergonlogic Montréal, Québec 🇨🇦

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024